All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com,
	Huang Shijie <shijie8@gmail.com>,
	dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE
Date: Wed, 15 Aug 2012 16:54:05 +0800	[thread overview]
Message-ID: <502B63AD.4000604@freescale.com> (raw)
In-Reply-To: <20120815100655.479e2c39@pixies.home.jungo.com>

于 2012年08月15日 15:06, Shmulik Ladkani 写道:
> Hi Huang,
>
> On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie<shijie8@gmail.com>  wrote:
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 588e989..0ca7257 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -22,15 +22,6 @@ menuconfig MTD_NAND
>>
>>   if MTD_NAND
>>
>> -config MTD_NAND_VERIFY_WRITE
>> -	bool "Verify NAND page writes"
>> -	help
>> -	  This adds an extra check when data is written to the flash. The
>> -	  NAND flash device internally checks only bits transitioning
>> -	  from 1 to 0. There is a rare possibility that even though the
>> -	  device thinks the write was successful, a bit could have been
>> -	  flipped accidentally due to device wear or something else.
>> -
> There are some defconfig files which set CONFIG_MTD_NAND_VERIFY_WRITE.
>
> I guess you should submit an accompanying patch that removes
> CONFIG_MTD_NAND_VERIFY_WRITE from all defconfig files.
>
thanks a lot.

I will send out a separate patch to fix it.

Huang Shijie
> (also, trimmed the CC list for this specific discussion, seems unrelated
> to all of the parties)
>
> Regards,
> Shmulik
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Huang Shijie <shijie8@gmail.com>, <linux-mtd@lists.infradead.org>,
	<dwmw2@infradead.org>, <linux-kernel@vger.kernel.org>,
	<dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE
Date: Wed, 15 Aug 2012 16:54:05 +0800	[thread overview]
Message-ID: <502B63AD.4000604@freescale.com> (raw)
In-Reply-To: <20120815100655.479e2c39@pixies.home.jungo.com>

于 2012年08月15日 15:06, Shmulik Ladkani 写道:
> Hi Huang,
>
> On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie<shijie8@gmail.com>  wrote:
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 588e989..0ca7257 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -22,15 +22,6 @@ menuconfig MTD_NAND
>>
>>   if MTD_NAND
>>
>> -config MTD_NAND_VERIFY_WRITE
>> -	bool "Verify NAND page writes"
>> -	help
>> -	  This adds an extra check when data is written to the flash. The
>> -	  NAND flash device internally checks only bits transitioning
>> -	  from 1 to 0. There is a rare possibility that even though the
>> -	  device thinks the write was successful, a bit could have been
>> -	  flipped accidentally due to device wear or something else.
>> -
> There are some defconfig files which set CONFIG_MTD_NAND_VERIFY_WRITE.
>
> I guess you should submit an accompanying patch that removes
> CONFIG_MTD_NAND_VERIFY_WRITE from all defconfig files.
>
thanks a lot.

I will send out a separate patch to fix it.

Huang Shijie
> (also, trimmed the CC list for this specific discussion, seems unrelated
> to all of the parties)
>
> Regards,
> Shmulik
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>



  reply	other threads:[~2012-08-15  8:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15  2:38 [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE Huang Shijie
2012-08-15  2:38 ` Huang Shijie
2012-08-15  2:38 ` Huang Shijie
2012-08-15  7:06 ` Shmulik Ladkani
2012-08-15  7:06   ` Shmulik Ladkani
2012-08-15  8:54   ` Huang Shijie [this message]
2012-08-15  8:54     ` Huang Shijie
2012-08-15 12:09     ` Marek Vasut
2012-08-15 12:09       ` Marek Vasut
2012-08-16  9:17       ` Huang Shijie
2012-08-16  9:17         ` Huang Shijie
2012-08-16 14:57         ` Marek Vasut
2012-08-16 14:57           ` Marek Vasut
2012-08-24 14:23 ` Artem Bityutskiy
2012-08-24 14:23   ` Artem Bityutskiy
2012-08-24 14:23   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502B63AD.4000604@freescale.com \
    --to=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shijie8@gmail.com \
    --cc=shmulik.ladkani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.