All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V2 0/6] ARM: tegra: add CPU hotplug support
Date: Wed, 15 Aug 2012 10:05:18 -0600	[thread overview]
Message-ID: <502BC8BE.8060800@wwwdotorg.org> (raw)
In-Reply-To: <1345022554-26292-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 08/15/2012 03:22 AM, Joseph Lo wrote:
> This patch set adds CPU hotplug support for Tegra20 and Tegra30 SoCs.
> 
> The first 3 patches make the CPU clock and reset control be a module and
> the abstraction APIs for TegraXX SoCs. And clean up some codes for later
> usage. Then add CPU hotplug support for Tegra20 and Tegra30.
> 
> Verified on Seaboard(Tegra20) and Cardhu(Tegra30)
> 
> V2:
> * add one more patch for enable HOTPLUG_CPU [6/6]

The build problem when HOTPLUG_CPU is disabled is still present. The
kernel needs to build with this option disabled.

Enabling HOTPLUG_CPU in defconfig doesn't force everyone to enable that
configuration option; not everyone uses tegra_defconfig, people don't
always update to the latest defconfig, people should be free to disable
functionality they don't need and still get a buildable & working
kernel, etc.

Besides, even if defconfig were a legitimate solution to this problem,
this series still wouldn't work with "git bisect", since the defconfig
patch comes after the patch that causes the build failure.

> * move all the SoC specific CPU shutdown code into platform_cpu_die [4/6]

The reboot problem is indeed solved.

P.S. It'd be nice to include a summary of what changed in each affected
patch, as well as in the cover letter.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 0/6] ARM: tegra: add CPU hotplug support
Date: Wed, 15 Aug 2012 10:05:18 -0600	[thread overview]
Message-ID: <502BC8BE.8060800@wwwdotorg.org> (raw)
In-Reply-To: <1345022554-26292-1-git-send-email-josephl@nvidia.com>

On 08/15/2012 03:22 AM, Joseph Lo wrote:
> This patch set adds CPU hotplug support for Tegra20 and Tegra30 SoCs.
> 
> The first 3 patches make the CPU clock and reset control be a module and
> the abstraction APIs for TegraXX SoCs. And clean up some codes for later
> usage. Then add CPU hotplug support for Tegra20 and Tegra30.
> 
> Verified on Seaboard(Tegra20) and Cardhu(Tegra30)
> 
> V2:
> * add one more patch for enable HOTPLUG_CPU [6/6]

The build problem when HOTPLUG_CPU is disabled is still present. The
kernel needs to build with this option disabled.

Enabling HOTPLUG_CPU in defconfig doesn't force everyone to enable that
configuration option; not everyone uses tegra_defconfig, people don't
always update to the latest defconfig, people should be free to disable
functionality they don't need and still get a buildable & working
kernel, etc.

Besides, even if defconfig were a legitimate solution to this problem,
this series still wouldn't work with "git bisect", since the defconfig
patch comes after the patch that causes the build failure.

> * move all the SoC specific CPU shutdown code into platform_cpu_die [4/6]

The reboot problem is indeed solved.

P.S. It'd be nice to include a summary of what changed in each affected
patch, as well as in the cover letter.

  parent reply	other threads:[~2012-08-15 16:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15  9:22 [PATCH V2 0/6] ARM: tegra: add CPU hotplug support Joseph Lo
2012-08-15  9:22 ` Joseph Lo
     [not found] ` <1345022554-26292-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-15  9:22   ` [PATCH V2 1/6] ARM: tegra: introduce tegra_cpu_car_ops structures Joseph Lo
2012-08-15  9:22     ` Joseph Lo
2012-08-15  9:22   ` [PATCH V2 2/6] ARM: tegra: replace the CPU CAR access code by tegra_cpu_car_ops Joseph Lo
2012-08-15  9:22     ` Joseph Lo
2012-08-15  9:22   ` [PATCH V2 3/6] ARM: tegra: clean up the common assembly macros into sleep.h Joseph Lo
2012-08-15  9:22     ` Joseph Lo
2012-08-15  9:22   ` [PATCH V2 4/6] ARM: tegra30: add CPU hotplug support Joseph Lo
2012-08-15  9:22     ` Joseph Lo
2012-08-15  9:22   ` [PATCH V2 5/6] ARM: tegra20: " Joseph Lo
2012-08-15  9:22     ` Joseph Lo
2012-08-15  9:22   ` [PATCH V2 6/6] ARM: tegra: defconfig: enable HOTPLUG_CPU Joseph Lo
2012-08-15  9:22     ` Joseph Lo
2012-08-15 16:05   ` Stephen Warren [this message]
2012-08-15 16:05     ` [PATCH V2 0/6] ARM: tegra: add CPU hotplug support Stephen Warren
     [not found]     ` <502BC8BE.8060800-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-16  9:30       ` Joseph Lo
2012-08-16  9:30         ` Joseph Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BC8BE.8060800@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.