Acer-WMI disables touchpad and other issues

Acer-WMI disables touchpad and other issues

[Nathanael D. Noblet]

Hello,

   I recently purchased an Acer Aspire One (model A0275-0691). It has an 
elantech touchpad. As detailed in this bug: 
https://bugzilla.redhat.com/show_bug.cgi?id=848270 the acer-wmi driver 
has two issues on this device.

#1) It is sending TOUCHPAD_TOGGLE and simultaneously changing state
#2) It disables the touchpad at init

It should apparently be doing neither of those. If I boot with acer-wmi 
blacklisted the touchpad works perfectly, all other Fn+key combos work 
other than brightness control.


-- 
Nathanael d. Noblet
t 403.875.4613

Re: Acer-WMI disables touchpad and other issues

[joeyli]

Hi Nathanael

於 三，2012-08-15 於 10:45 -0600，Nathanael D. Noblet 提到：
> Hello,
> 
>    I recently purchased an Acer Aspire One (model A0275-0691). It has an 
> elantech touchpad. As detailed in this bug: 
> https://bugzilla.redhat.com/show_bug.cgi?id=848270 the acer-wmi driver 
> has two issues on this device.
> 
> #1) It is sending TOUCHPAD_TOGGLE and simultaneously changing state
> #2) It disables the touchpad at init
> 
> It should apparently be doing neither of those. If I boot with acer-wmi 
> blacklisted the touchpad works perfectly, all other Fn+key combos work 
> other than brightness control.
> 
> 

Please help to test this testing patch. And, please attach dmidecode on
bugzilla or here. 
If this testing patch can avoid problem on your machine, then I will
write code to parser the dmidecode information for grab the acpi code of
touchpad.


Thanks a lot!
Joey Lee


From 969d1c0bb4fc4b69ef9d037687b4591fbd9df24f Mon Sep 17 00:00:00 2001
From: Lee, Chun-Yi <jlee@suse.com>
Date: Thu, 16 Aug 2012 11:28:20 +0800
Subject: [PATCH] acer-wmi: test patch for remove 0x82 acpi event with KEY_TOUCHPAD_TOGGLE


Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 3782e1c..db7376b 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -125,7 +125,7 @@ static const struct key_entry acer_wmi_keymap[] = {
 	{KE_IGNORE, 0x63, {KEY_BRIGHTNESSDOWN} },
 	{KE_KEY, 0x64, {KEY_SWITCHVIDEOMODE} },	/* Display Switch */
 	{KE_IGNORE, 0x81, {KEY_SLEEP} },
-	{KE_KEY, 0x82, {KEY_TOUCHPAD_TOGGLE} },	/* Touch Pad On/Off */
+//	{KE_KEY, 0x82, {KEY_TOUCHPAD_TOGGLE} },	/* Touch Pad On/Off */
 	{KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_END, 0}
 };
-- 
1.6.0.2

Re: Acer-WMI disables touchpad and other issues

[Nathanael D. Noblet]

On 08/15/2012 10:45 AM, Nathanael D. Noblet wrote:
> Hello,
>
>    I recently purchased an Acer Aspire One (model A0275-0691). It has an
> elantech touchpad. As detailed in this bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=848270 the acer-wmi driver
> has two issues on this device.
>
> #1) It is sending TOUCHPAD_TOGGLE and simultaneously changing state
> #2) It disables the touchpad at init

So I tested the patch provided here. 
https://bugzilla.redhat.com/show_bug.cgi?id=848270

It definitely allows the Fn+F7 key combo to toggle the use of the 
mousepad. Unfortunately the mousepad comes up disabled and is very much 
confusing the users using the device. Is there somewhere I should look 
for what is causing that? I don't mind helping to debug the issue at all 
I just don't know where to start.

Thanks,
-- 
Nathanael d. Noblet
t 403.875.4613

Re: Acer-WMI disables touchpad and other issues

[joeyli]

Hi Nathanael, 

於 三，2012-09-12 於 22:35 -0600，Nathanael D. Noblet 提到：
> On 08/15/2012 10:45 AM, Nathanael D. Noblet wrote:
> > Hello,
> >
> >    I recently purchased an Acer Aspire One (model A0275-0691). It has an
> > elantech touchpad. As detailed in this bug:
> > https://bugzilla.redhat.com/show_bug.cgi?id=848270 the acer-wmi driver
> > has two issues on this device.
> >
> > #1) It is sending TOUCHPAD_TOGGLE and simultaneously changing state
> > #2) It disables the touchpad at init
> 
> So I tested the patch provided here. 
> https://bugzilla.redhat.com/show_bug.cgi?id=848270
> 
> It definitely allows the Fn+F7 key combo to toggle the use of the 
> mousepad. Unfortunately the mousepad comes up disabled and is very much 
> confusing the users using the device. Is there somewhere I should look 
> for what is causing that? I don't mind helping to debug the issue at all 
> I just don't know where to start.
> 
> Thanks,

Please try 'ec_raw_mode=1' acer-wmi parameter to avoid acer-wmi run
launch manager mode. Run the following statement through root and reboot
system:
	# echo "options acer-wmi ec_raw_mode=1" > /etc/modprobe.d/acer-wmi.conf


On the other hand,
I checked your dmideocde on brc#848720, the 0x82 is the RIGHT acpi code
to you for touchpad_toggle key, that means acer-wmi should emit
KEY_TOUCHPAD_TOGGLE to userland. There have another thing also listen
the KEY_TOUCHPAD_TOGGLE and do the change. I checked the
gnome-settings-daemon, it just show up OSD but didn't change touchpad
status.

Could you please help provide the following information?
	+ please attach acpidump:
		# acpidump > acpidump.dat
	+ please help to capture acpi debug log:
		+ please remove ec_raw_mode=1 first.
		+ check your kernel parameter need enable: 'CONFIG_ACPI_DEBUG=y'
		+ please add the following kernel parameter and reboot system:
			acpi.debug_level=0x0000000F acpi.debug_layer=0xffffffff log_buf_len=5M
		+ after system reboot, please press Fn+F11 (touchpad toggle key) a couple of times.
		+ please attach on dmesg log.

For your backlight function key problem, please file another bug on
bugzilla.kernel.org.



Thanks a lot!
Joey Lee

Re: Acer-WMI disables touchpad and other issues

[Nathanael D. Noblet]

So far I've added the options acer-wmi ec_raw_mode=1 to a modprobe.d 
conf file. Looking at /sys/modules/acer_wmi/parameters/ec_raw_mode 
contains a Y. The mousepad remains unresponsive on boot prior to a 
Fn+F7. I've added options acer_wmi ec_raw_mode=1 (note the acer_wmi vs 
acer-wmi) simply because the sysmodule was also underscore. There is no 
difference, the module parameter is recorded as Y and the mousepad still 
does not work on boot.

I will provide the other requested information soon.

On 09/13/2012 04:05 AM, joeyli wrote:
> Hi Nathanael,
>
> 於 三，2012-09-12 於 22:35 -0600，Nathanael D. Noblet 提到：
>> On 08/15/2012 10:45 AM, Nathanael D. Noblet wrote:
>>> Hello,
>>>
>>>     I recently purchased an Acer Aspire One (model A0275-0691). It has an
>>> elantech touchpad. As detailed in this bug:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=848270 the acer-wmi driver
>>> has two issues on this device.
>>>
>>> #1) It is sending TOUCHPAD_TOGGLE and simultaneously changing state
>>> #2) It disables the touchpad at init
>>
>> So I tested the patch provided here.
>> https://bugzilla.redhat.com/show_bug.cgi?id=848270
>>
>> It definitely allows the Fn+F7 key combo to toggle the use of the
>> mousepad. Unfortunately the mousepad comes up disabled and is very much
>> confusing the users using the device. Is there somewhere I should look
>> for what is causing that? I don't mind helping to debug the issue at all
>> I just don't know where to start.
>>
>> Thanks,
>
> Please try 'ec_raw_mode=1' acer-wmi parameter to avoid acer-wmi run
> launch manager mode. Run the following statement through root and reboot
> system:
> 	# echo "options acer-wmi ec_raw_mode=1" > /etc/modprobe.d/acer-wmi.conf
>
>
> On the other hand,
> I checked your dmideocde on brc#848720, the 0x82 is the RIGHT acpi code
> to you for touchpad_toggle key, that means acer-wmi should emit
> KEY_TOUCHPAD_TOGGLE to userland. There have another thing also listen
> the KEY_TOUCHPAD_TOGGLE and do the change. I checked the
> gnome-settings-daemon, it just show up OSD but didn't change touchpad
> status.
>
> Could you please help provide the following information?
> 	+ please attach acpidump:
> 		# acpidump > acpidump.dat
> 	+ please help to capture acpi debug log:
> 		+ please remove ec_raw_mode=1 first.
> 		+ check your kernel parameter need enable: 'CONFIG_ACPI_DEBUG=y'
> 		+ please add the following kernel parameter and reboot system:
> 			acpi.debug_level=0x0000000F acpi.debug_layer=0xffffffff log_buf_len=5M
> 		+ after system reboot, please press Fn+F11 (touchpad toggle key) a couple of times.
> 		+ please attach on dmesg log.
>
> For your backlight function key problem, please file another bug on
> bugzilla.kernel.org.
>
>
>
> Thanks a lot!
> Joey Lee
>
>


-- 
Nathanael d. Noblet
t 403.875.4613

Re: Acer-WMI disables touchpad and other issues

[joeyli]

於 四，2012-09-13 於 09:27 -0600，Nathanael D. Noblet 提到：
> So far I've added the options acer-wmi ec_raw_mode=1 to a modprobe.d 
> conf file. Looking at /sys/modules/acer_wmi/parameters/ec_raw_mode 
> contains a Y. The mousepad remains unresponsive on boot prior to a 
> Fn+F7. I've added options acer_wmi ec_raw_mode=1 (note the acer_wmi vs 
> acer-wmi) simply because the sysmodule was also underscore. There is no 
> difference, the module parameter is recorded as Y and the mousepad still 
> does not work on boot.
> 
> I will provide the other requested information soon.

Thanks for your testing, then we need to see DSDT and acpi debug log
when load acer-wmi.


Thanks
Joey Lee

> 
> On 09/13/2012 04:05 AM, joeyli wrote:
> > Hi Nathanael,
> >
> > 於 三，2012-09-12 於 22:35 -0600，Nathanael D. Noblet 提到：
> >> On 08/15/2012 10:45 AM, Nathanael D. Noblet wrote:
> >>> Hello,
> >>>
> >>>     I recently purchased an Acer Aspire One (model A0275-0691). It has an
> >>> elantech touchpad. As detailed in this bug:
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=848270 the acer-wmi driver
> >>> has two issues on this device.
> >>>
> >>> #1) It is sending TOUCHPAD_TOGGLE and simultaneously changing state
> >>> #2) It disables the touchpad at init
> >>
> >> So I tested the patch provided here.
> >> https://bugzilla.redhat.com/show_bug.cgi?id=848270
> >>
> >> It definitely allows the Fn+F7 key combo to toggle the use of the
> >> mousepad. Unfortunately the mousepad comes up disabled and is very much
> >> confusing the users using the device. Is there somewhere I should look
> >> for what is causing that? I don't mind helping to debug the issue at all
> >> I just don't know where to start.
> >>
> >> Thanks,
> >
> > Please try 'ec_raw_mode=1' acer-wmi parameter to avoid acer-wmi run
> > launch manager mode. Run the following statement through root and reboot
> > system:
> > 	# echo "options acer-wmi ec_raw_mode=1" > /etc/modprobe.d/acer-wmi.conf
> >
> >
> > On the other hand,
> > I checked your dmideocde on brc#848720, the 0x82 is the RIGHT acpi code
> > to you for touchpad_toggle key, that means acer-wmi should emit
> > KEY_TOUCHPAD_TOGGLE to userland. There have another thing also listen
> > the KEY_TOUCHPAD_TOGGLE and do the change. I checked the
> > gnome-settings-daemon, it just show up OSD but didn't change touchpad
> > status.
> >
> > Could you please help provide the following information?
> > 	+ please attach acpidump:
> > 		# acpidump > acpidump.dat
> > 	+ please help to capture acpi debug log:
> > 		+ please remove ec_raw_mode=1 first.
> > 		+ check your kernel parameter need enable: 'CONFIG_ACPI_DEBUG=y'
> > 		+ please add the following kernel parameter and reboot system:
> > 			acpi.debug_level=0x0000000F acpi.debug_layer=0xffffffff log_buf_len=5M
> > 		+ after system reboot, please press Fn+F11 (touchpad toggle key) a couple of times.
> > 		+ please attach on dmesg log.
> >
> > For your backlight function key problem, please file another bug on
> > bugzilla.kernel.org.
> >
> >
> >
> > Thanks a lot!
> > Joey Lee
> >
> >
> 
> 

Re: Acer-WMI disables touchpad and other issues

[Nathanael D. Noblet]

Hello Joey li,

On 09/13/2012 04:05 AM, joeyli wrote:
> On the other hand,
> I checked your dmideocde on brc#848720, the 0x82 is the RIGHT acpi code
> to you for touchpad_toggle key, that means acer-wmi should emit
> KEY_TOUCHPAD_TOGGLE to userland. There have another thing also listen
> the KEY_TOUCHPAD_TOGGLE and do the change. I checked the
> gnome-settings-daemon, it just show up OSD but didn't change touchpad
> status.

I was discussing this with Matthew Garrett in #fedora-kernel. He's 
telling me that if the hardware does the enabling/disabling that it 
should not emit _TOGGLE, but that it should emit KEY_TOUCHPAD_ON or 
KEY_TOUCHPAD_OFF instead. I'm in no place to know one way or the other. 
I've CC'd him on this so the discussion of the issue can continue to 
figure out what the source problem is.


Thanks again for the help, I'll get the acipdump and dmesg logs sometime 
today.

-- 
Nathanael d. Noblet
t 403.875.4613

Re: Acer-WMI disables touchpad and other issues

[Matthew Garrett]

On Thu, Sep 13, 2012 at 09:47:06AM -0600, Nathanael D. Noblet wrote:
> Hello Joey li,
> 
> On 09/13/2012 04:05 AM, joeyli wrote:
> >On the other hand,
> >I checked your dmideocde on brc#848720, the 0x82 is the RIGHT acpi code
> >to you for touchpad_toggle key, that means acer-wmi should emit
> >KEY_TOUCHPAD_TOGGLE to userland. There have another thing also listen
> >the KEY_TOUCHPAD_TOGGLE and do the change. I checked the
> >gnome-settings-daemon, it just show up OSD but didn't change touchpad
> >status.
> 
> I was discussing this with Matthew Garrett in #fedora-kernel. He's
> telling me that if the hardware does the enabling/disabling that it
> should not emit _TOGGLE, but that it should emit KEY_TOUCHPAD_ON or
> KEY_TOUCHPAD_OFF instead. I'm in no place to know one way or the
> other. I've CC'd him on this so the discussion of the issue can
> continue to figure out what the source problem is.

Right - TOUCHPAD_TOGGLE is a request from the hardware that the desktop 
environment change the state. In this case hitting the key is causing 
the hardware to change its state directly, and therefore it should just 
be sending KEY_TOUCHPAD_ON or KEY_TOUCHPAD_OFF.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Acer-WMI disables touchpad and other issues

[joeyli]

於 四，2012-09-13 於 17:03 +0100，Matthew Garrett 提到：
> On Thu, Sep 13, 2012 at 09:47:06AM -0600, Nathanael D. Noblet wrote:
> > Hello Joey li,
> > 
> > On 09/13/2012 04:05 AM, joeyli wrote:
> > >On the other hand,
> > >I checked your dmideocde on brc#848720, the 0x82 is the RIGHT acpi code
> > >to you for touchpad_toggle key, that means acer-wmi should emit
> > >KEY_TOUCHPAD_TOGGLE to userland. There have another thing also listen
> > >the KEY_TOUCHPAD_TOGGLE and do the change. I checked the
> > >gnome-settings-daemon, it just show up OSD but didn't change touchpad
> > >status.
> > 
> > I was discussing this with Matthew Garrett in #fedora-kernel. He's
> > telling me that if the hardware does the enabling/disabling that it
> > should not emit _TOGGLE, but that it should emit KEY_TOUCHPAD_ON or
> > KEY_TOUCHPAD_OFF instead. I'm in no place to know one way or the
> > other. I've CC'd him on this so the discussion of the issue can
> > continue to figure out what the source problem is.
> 
> Right - TOUCHPAD_TOGGLE is a request from the hardware that the desktop 
> environment change the state. In this case hitting the key is causing 
> the hardware to change its state directly, and therefore it should just 
> be sending KEY_TOUCHPAD_ON or KEY_TOUCHPAD_OFF.
> 

Got it!
We need check the DSDT for look at if there have any wmi used to grab
the touchpad status.


Thanks
Joey Lee