All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
	Mitch Bradley <wmb@firmworks.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 00/10] ARM: tegra: Add PCIe device tree support
Date: Wed, 15 Aug 2012 14:11:10 -0600	[thread overview]
Message-ID: <502C025E.6000009@wwwdotorg.org> (raw)
In-Reply-To: <20120815200905.GD12870@avionic-0098.mockup.avionic-design.de>

On 08/15/2012 02:09 PM, Thierry Reding wrote:
> On Wed, Aug 15, 2012 at 01:04:20PM -0600, Stephen Warren wrote:
>> On 08/14/2012 05:51 PM, Stephen Warren wrote:
>>> On 08/14/2012 04:58 PM, Stephen Warren wrote:
>> ...
>>>> Can't we make the call to pci_bus_add_devices() optional in 
>>>> pci_scan_root_bus() somehow; one of:
>>> 
>>> Sigh, that turns out not to work correctly; it solves at least
>>> this part of the problem when booting using device tree, but
>>> when booting using a board file, it causes the IRQ number
>>> passed to the PCIe device to be bogus:-(
>>> 
>>> I give up for now.
>> 
>> I think the appropriate workaround for Tegra in 3.6 is to simply
>> make any drivers for PCIe-based devices be modules instead of
>> built-in, as Thierry hinted at much earlier in the thread. I've
>> validated that the Ethernet works just fine on TrimSlice with
>> that change, booting v3.6-rc1 using either board files or device
>> tree.
> 
> That's certainly the easiest and least error-prone solution.
> 
>> For 3.7, we should continue the discussion about a real fix; I'll
>> look into the change Bjorn requested and see if it works,
>> although given that hacking pci_scan_root_bus as described
>> immediately previously in this thread caused a regression when
>> booting using a board file, and the fact that board files are no
>> longer supported on Tegra, I'm not too confident in the
>> outcome...
> 
> I don't understand this last part. If the problem is there when
> booting from board files and the board files are removed, doesn't
> that remove the problem as well? =)

It does for ARM SoCs/CPUs exclusively using device tree, but not all
ARM systems are converting to device tree, so the fact that Tegra has
makes it harder for me not to break anything else.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
	<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Mitch Bradley <wmb-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH v3 00/10] ARM: tegra: Add PCIe device tree support
Date: Wed, 15 Aug 2012 14:11:10 -0600	[thread overview]
Message-ID: <502C025E.6000009@wwwdotorg.org> (raw)
In-Reply-To: <20120815200905.GD12870-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>

On 08/15/2012 02:09 PM, Thierry Reding wrote:
> On Wed, Aug 15, 2012 at 01:04:20PM -0600, Stephen Warren wrote:
>> On 08/14/2012 05:51 PM, Stephen Warren wrote:
>>> On 08/14/2012 04:58 PM, Stephen Warren wrote:
>> ...
>>>> Can't we make the call to pci_bus_add_devices() optional in 
>>>> pci_scan_root_bus() somehow; one of:
>>> 
>>> Sigh, that turns out not to work correctly; it solves at least
>>> this part of the problem when booting using device tree, but
>>> when booting using a board file, it causes the IRQ number
>>> passed to the PCIe device to be bogus:-(
>>> 
>>> I give up for now.
>> 
>> I think the appropriate workaround for Tegra in 3.6 is to simply
>> make any drivers for PCIe-based devices be modules instead of
>> built-in, as Thierry hinted at much earlier in the thread. I've
>> validated that the Ethernet works just fine on TrimSlice with
>> that change, booting v3.6-rc1 using either board files or device
>> tree.
> 
> That's certainly the easiest and least error-prone solution.
> 
>> For 3.7, we should continue the discussion about a real fix; I'll
>> look into the change Bjorn requested and see if it works,
>> although given that hacking pci_scan_root_bus as described
>> immediately previously in this thread caused a regression when
>> booting using a board file, and the fact that board files are no
>> longer supported on Tegra, I'm not too confident in the
>> outcome...
> 
> I don't understand this last part. If the problem is there when
> booting from board files and the board files are removed, doesn't
> that remove the problem as well? =)

It does for ARM SoCs/CPUs exclusively using device tree, but not all
ARM systems are converting to device tree, so the fact that Tegra has
makes it harder for me not to break anything else.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 00/10] ARM: tegra: Add PCIe device tree support
Date: Wed, 15 Aug 2012 14:11:10 -0600	[thread overview]
Message-ID: <502C025E.6000009@wwwdotorg.org> (raw)
In-Reply-To: <20120815200905.GD12870@avionic-0098.mockup.avionic-design.de>

On 08/15/2012 02:09 PM, Thierry Reding wrote:
> On Wed, Aug 15, 2012 at 01:04:20PM -0600, Stephen Warren wrote:
>> On 08/14/2012 05:51 PM, Stephen Warren wrote:
>>> On 08/14/2012 04:58 PM, Stephen Warren wrote:
>> ...
>>>> Can't we make the call to pci_bus_add_devices() optional in 
>>>> pci_scan_root_bus() somehow; one of:
>>> 
>>> Sigh, that turns out not to work correctly; it solves at least
>>> this part of the problem when booting using device tree, but
>>> when booting using a board file, it causes the IRQ number
>>> passed to the PCIe device to be bogus:-(
>>> 
>>> I give up for now.
>> 
>> I think the appropriate workaround for Tegra in 3.6 is to simply
>> make any drivers for PCIe-based devices be modules instead of
>> built-in, as Thierry hinted at much earlier in the thread. I've
>> validated that the Ethernet works just fine on TrimSlice with
>> that change, booting v3.6-rc1 using either board files or device
>> tree.
> 
> That's certainly the easiest and least error-prone solution.
> 
>> For 3.7, we should continue the discussion about a real fix; I'll
>> look into the change Bjorn requested and see if it works,
>> although given that hacking pci_scan_root_bus as described
>> immediately previously in this thread caused a regression when
>> booting using a board file, and the fact that board files are no
>> longer supported on Tegra, I'm not too confident in the
>> outcome...
> 
> I don't understand this last part. If the problem is there when
> booting from board files and the board files are removed, doesn't
> that remove the problem as well? =)

It does for ARM SoCs/CPUs exclusively using device tree, but not all
ARM systems are converting to device tree, so the fact that Tegra has
makes it harder for me not to break anything else.

  reply	other threads:[~2012-08-15 20:11 UTC|newest]

Thread overview: 209+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 19:55 [PATCH v3 00/10] ARM: tegra: Add PCIe device tree support Thierry Reding
2012-07-26 19:55 ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-08-14  5:06   ` Bjorn Helgaas
2012-08-14  5:06     ` Bjorn Helgaas
2012-08-14  5:37     ` Thierry Reding
2012-08-14  5:37       ` Thierry Reding
2012-08-14  5:37       ` Thierry Reding
2012-08-15 17:06   ` Bjorn Helgaas
2012-08-15 17:06     ` Bjorn Helgaas
2012-08-15 17:06     ` Bjorn Helgaas
2012-08-15 19:28     ` Thierry Reding
2012-08-15 19:28       ` Thierry Reding
2012-08-15 19:42       ` Bjorn Helgaas
2012-08-15 19:42         ` Bjorn Helgaas
2012-08-15 20:01         ` Thierry Reding
2012-08-15 20:01           ` Thierry Reding
2012-08-15 20:01           ` Thierry Reding
2012-09-07 16:19         ` Stephen Warren
2012-09-07 16:19           ` Stephen Warren
2012-09-07 16:19           ` Stephen Warren
2012-09-07 17:00           ` Thierry Reding
2012-09-07 17:00             ` Thierry Reding
2012-09-07 17:00             ` Thierry Reding
2012-09-07 17:22             ` Bjorn Helgaas
2012-09-07 17:22               ` Bjorn Helgaas
2012-09-14 18:55               ` Thierry Reding
2012-09-14 18:55                 ` Thierry Reding
2012-09-14 18:55                 ` Thierry Reding
2012-09-14 19:45                 ` Bjorn Helgaas
2012-09-14 19:45                   ` Bjorn Helgaas
2012-09-14 19:45                   ` Bjorn Helgaas
2012-07-26 19:55 ` [PATCH v3 02/10] ARM: pci: Keep pci_common_init() " Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 03/10] ARM: pci: Allow passing per-controller private data Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 04/10] ARM: tegra: Move tegra_pcie_xclk_clamp() to PMC Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 05/10] resource: add PCI configuration space support Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-08-14  5:00   ` Bjorn Helgaas
2012-08-14  5:00     ` Bjorn Helgaas
2012-08-14  5:00     ` Bjorn Helgaas
2012-08-14  5:55     ` Thierry Reding
2012-08-14  5:55       ` Thierry Reding
2012-08-14  5:55       ` Thierry Reding
2012-08-14 17:38       ` Bjorn Helgaas
2012-08-14 17:38         ` Bjorn Helgaas
2012-08-14 18:01         ` Thierry Reding
2012-08-14 18:01           ` Thierry Reding
2012-08-14 18:01           ` Thierry Reding
2012-08-14 21:44           ` Bjorn Helgaas
2012-08-14 21:44             ` Bjorn Helgaas
2012-08-15  6:49             ` Thierry Reding
2012-08-15  6:49               ` Thierry Reding
2012-08-15  6:49               ` Thierry Reding
2012-08-16 15:18               ` Stephen Warren
2012-08-16 15:18                 ` Stephen Warren
2012-08-16 15:18                 ` Stephen Warren
2012-08-16 18:27                 ` Thierry Reding
2012-08-16 18:27                   ` Thierry Reding
2012-08-16 18:27                   ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 06/10] ARM: tegra: Rewrite PCIe support as a driver Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 07/10] ARM: tegra: pcie: Add MSI support Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55 ` [PATCH v3 08/10] of/address: Handle #address-cells > 2 specially Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-31 20:18   ` Rob Herring
2012-07-31 20:18     ` Rob Herring
2012-07-31 20:18     ` Rob Herring
2012-08-15 20:06     ` Thierry Reding
2012-08-15 20:06       ` Thierry Reding
2012-09-07 16:24       ` Stephen Warren
2012-09-07 16:24         ` Stephen Warren
2012-09-07 16:24         ` Stephen Warren
2012-09-07 16:32         ` Rob Herring
2012-09-07 16:32           ` Rob Herring
2012-09-07 16:32           ` Rob Herring
2012-07-26 19:55 ` [PATCH v3 09/10] of: Add of_pci_parse_ranges() Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-07-31 20:07   ` Rob Herring
2012-07-31 20:07     ` Rob Herring
2012-08-01  6:54     ` Thierry Reding
2012-08-01  6:54       ` Thierry Reding
2012-08-01  6:54       ` Thierry Reding
2012-08-01 16:07       ` Stephen Warren
2012-08-01 16:07         ` Stephen Warren
2012-08-01 16:07         ` Stephen Warren
2012-07-26 19:55 ` [PATCH v3 10/10] ARM: tegra: pcie: Add device tree support Thierry Reding
2012-07-26 19:55   ` Thierry Reding
2012-08-14 20:12   ` Thierry Reding
2012-08-14 20:12     ` Thierry Reding
2012-08-14 20:12     ` Thierry Reding
2012-08-14 23:50     ` Bjorn Helgaas
2012-08-14 23:50       ` Bjorn Helgaas
2012-08-15  6:37       ` Thierry Reding
2012-08-15  6:37         ` Thierry Reding
2012-08-15 12:18         ` Bjorn Helgaas
2012-08-15 12:18           ` Bjorn Helgaas
2012-08-15 12:30           ` Thierry Reding
2012-08-15 12:30             ` Thierry Reding
2012-08-15 12:30             ` Thierry Reding
2012-08-15 14:36             ` Bjorn Helgaas
2012-08-15 14:36               ` Bjorn Helgaas
2012-08-15 14:36               ` Bjorn Helgaas
2012-08-15 14:57               ` Thierry Reding
2012-08-15 14:57                 ` Thierry Reding
2012-08-15 14:57                 ` Thierry Reding
2012-08-15 20:25                 ` Arnd Bergmann
2012-08-15 20:25                   ` Arnd Bergmann
2012-08-15 20:25                   ` Arnd Bergmann
2012-08-15 20:48                   ` Bjorn Helgaas
2012-08-15 20:48                     ` Bjorn Helgaas
2012-08-15 20:48                     ` Bjorn Helgaas
2012-08-16  4:55                   ` Thierry Reding
2012-08-16  4:55                     ` Thierry Reding
2012-08-16  4:55                     ` Thierry Reding
2012-08-16  7:03                     ` Arnd Bergmann
2012-08-16  7:03                       ` Arnd Bergmann
2012-08-16  7:03                       ` Arnd Bergmann
2012-08-16  7:47                       ` Thierry Reding
2012-08-16  7:47                         ` Thierry Reding
2012-08-16  7:47                         ` Thierry Reding
2012-08-16 12:15           ` Thierry Reding
2012-08-16 12:15             ` Thierry Reding
2012-08-16 12:15             ` Thierry Reding
2012-07-31 16:18 ` [PATCH v3 00/10] ARM: tegra: Add PCIe " Stephen Warren
2012-07-31 16:18   ` Stephen Warren
2012-07-31 16:18   ` Stephen Warren
2012-08-01  6:35   ` Thierry Reding
2012-08-01  6:35     ` Thierry Reding
2012-08-01  6:35     ` Thierry Reding
2012-08-01 17:02     ` Stephen Warren
2012-08-01 17:02       ` Stephen Warren
2012-08-01 17:02       ` Stephen Warren
2012-08-02  6:15       ` Thierry Reding
2012-08-02  6:15         ` Thierry Reding
2012-08-02  6:15         ` Thierry Reding
2012-08-06 19:42 ` Stephen Warren
2012-08-06 19:42   ` Stephen Warren
2012-08-07 18:20   ` Thierry Reding
2012-08-07 18:20     ` Thierry Reding
2012-08-13 17:40   ` Thierry Reding
2012-08-13 17:40     ` Thierry Reding
2012-08-13 18:47     ` Stephen Warren
2012-08-13 18:47       ` Stephen Warren
2012-08-13 18:47       ` Stephen Warren
2012-08-13 20:33       ` Thierry Reding
2012-08-13 20:33         ` Thierry Reding
2012-08-13 20:33         ` Thierry Reding
2012-08-13 21:38         ` Rob Herring
2012-08-13 21:38           ` Rob Herring
2012-08-14  6:14           ` Thierry Reding
2012-08-14  6:14             ` Thierry Reding
2012-08-13 23:18       ` Bjorn Helgaas
2012-08-13 23:18         ` Bjorn Helgaas
2012-08-13 23:18         ` Bjorn Helgaas
2012-08-14  6:29         ` Thierry Reding
2012-08-14  6:29           ` Thierry Reding
2012-08-14  6:29           ` Thierry Reding
2012-08-14 19:39         ` Stephen Warren
2012-08-14 19:39           ` Stephen Warren
2012-08-14 19:58           ` Thierry Reding
2012-08-14 19:58             ` Thierry Reding
2012-08-14 19:58             ` Thierry Reding
2012-08-14 21:55             ` Bjorn Helgaas
2012-08-14 21:55               ` Bjorn Helgaas
2012-08-14 21:55               ` Bjorn Helgaas
2012-08-14 22:58               ` Stephen Warren
2012-08-14 22:58                 ` Stephen Warren
2012-08-14 22:58                 ` Stephen Warren
2012-08-14 23:51                 ` Stephen Warren
2012-08-14 23:51                   ` Stephen Warren
2012-08-14 23:51                   ` Stephen Warren
2012-08-15 19:04                   ` Stephen Warren
2012-08-15 19:04                     ` Stephen Warren
2012-08-15 19:04                     ` Stephen Warren
2012-08-15 20:09                     ` Thierry Reding
2012-08-15 20:09                       ` Thierry Reding
2012-08-15 20:11                       ` Stephen Warren [this message]
2012-08-15 20:11                         ` Stephen Warren
2012-08-15 20:11                         ` Stephen Warren
2012-08-15 20:19                         ` Thierry Reding
2012-08-15 20:19                           ` Thierry Reding
2012-08-15 20:19                           ` Thierry Reding
2012-09-07 23:34                   ` Stephen Warren
2012-09-07 23:34                     ` Stephen Warren
2012-09-08  0:04                     ` Russell King - ARM Linux
2012-09-08  0:04                       ` Russell King - ARM Linux
2012-09-08  0:04                       ` Russell King - ARM Linux
2012-09-08  5:53                       ` Stephen Warren
2012-09-08  5:53                         ` Stephen Warren
2012-09-08  5:53                         ` Stephen Warren
2012-09-08 17:51                       ` Bjorn Helgaas
2012-09-08 17:51                         ` Bjorn Helgaas
2012-09-08 17:51                         ` Bjorn Helgaas
2012-09-18  6:33                         ` Thierry Reding
2012-09-18  6:33                           ` Thierry Reding
2012-09-18 15:56                           ` Bjorn Helgaas
2012-09-18 15:56                             ` Bjorn Helgaas
2012-08-15  0:08                 ` Bjorn Helgaas
2012-08-15  0:08                   ` Bjorn Helgaas
2012-08-15  0:08                   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502C025E.6000009@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=ccross@android.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=rob.herring@calxeda.com \
    --cc=thierry.reding@avionic-design.de \
    --cc=wmb@firmworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.