From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: bridge@lists.linux-foundation.org, ursula.braun@de.ibm.com,
john.r.fastabend@intel.com, edumazet@google.com,
shemminger@vyatta.com, sean.hefty@intel.com, therbert@google.com,
roland@kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, fubar@us.ibm.com, fbl@redhat.com,
hal.rosenstock@gmail.com, faisal.latif@intel.com,
blaschka@linux.vnet.ibm.com, sony.chacko@qlogic.com,
linux-driver@qlogic.com,
Ben Hutchings <bhutchings@solarflare.com>,
xiyou.wangcong@gmail.com, jitendra.kalsaria@qlogic.com,
divy@chelsio.com, gregory.v.rose@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kaber@trash.net, joe@perches.com, linux390@de.ibm.com,
davem@davemloft.net
Subject: Re: [Bridge] [patch net-next 01/16] net: introduce upper device lists
Date: Wed, 15 Aug 2012 22:33:56 +0200 [thread overview]
Message-ID: <502C07B4.6050104@gmail.com> (raw)
In-Reply-To: <20120813173110.GA1808@minipsycho.orion>
Le 13/08/2012 19:31, Jiri Pirko a écrit :
> Mon, Aug 13, 2012 at 07:04:11PM CEST, bhutchings@solarflare.com wrote:
>>> +struct netdev_upper {
>>> + struct net_device *dev;
>>> + bool unique;
>>
>> This needs a better name. It doesn't really have anything to do with
>> uniqueness and doesn't ensure exclusivity. I think that it would be
>> fine to keep the 'master' term.
>
> Hmm. I admit that "unique" I do not like too much as well. But "master"
> I like even less.
>
> This flag should ensure exclusivity. Only one upper device with this
> flag can be present at a time.
Well, can't we simply call it "upper_device"?
And as we only have a single field, this is exclusive by design.
Nicolas.
WARNING: multiple messages have this Message-ID (diff)
From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: bridge@lists.linux-foundation.org, ursula.braun@de.ibm.com,
john.r.fastabend@intel.com, edumazet@google.com,
shemminger@vyatta.com, sean.hefty@intel.com, therbert@google.com,
roland@kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, fubar@us.ibm.com, fbl@redhat.com,
hal.rosenstock@gmail.com, faisal.latif@intel.com,
blaschka@linux.vnet.ibm.com, sony.chacko@qlogic.com,
linux-driver@qlogic.com,
Ben Hutchings <bhutchings@solarflare.com>,
xiyou.wangcong@gmail.com, jitendra.kalsaria@qlogic.com,
divy@chelsio.com, gregory.v.rose@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kaber@trash.net, joe@perches.com, linux390@de.ibm.com,
davem@davemloft.net
Subject: Re: [patch net-next 01/16] net: introduce upper device lists
Date: Wed, 15 Aug 2012 22:33:56 +0200 [thread overview]
Message-ID: <502C07B4.6050104@gmail.com> (raw)
In-Reply-To: <20120813173110.GA1808@minipsycho.orion>
Le 13/08/2012 19:31, Jiri Pirko a écrit :
> Mon, Aug 13, 2012 at 07:04:11PM CEST, bhutchings@solarflare.com wrote:
>>> +struct netdev_upper {
>>> + struct net_device *dev;
>>> + bool unique;
>>
>> This needs a better name. It doesn't really have anything to do with
>> uniqueness and doesn't ensure exclusivity. I think that it would be
>> fine to keep the 'master' term.
>
> Hmm. I admit that "unique" I do not like too much as well. But "master"
> I like even less.
>
> This flag should ensure exclusivity. Only one upper device with this
> flag can be present at a time.
Well, can't we simply call it "upper_device"?
And as we only have a single field, this is exclusive by design.
Nicolas.
WARNING: multiple messages have this Message-ID (diff)
From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
faisal.latif@intel.com, roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, fubar@us.ibm.com, andy@greyhouse.net,
divy@chelsio.com, jitendra.kalsaria@qlogic.com,
sony.chacko@qlogic.com, linux-driver@qlogic.com, kaber@trash.net,
ursula.braun@de.ibm.com, blaschka@linux.vnet.ibm.com,
linux390@de.ibm.com, shemminger@vyatta.com, therbert@google.com,
xiyou.wangcong@gmail.com, joe@perches.com,
gregory.v.rose@intel.com, john.r.fastabend@intel.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, bridge@lists.linux-foundation.org,
fbl@redhat.com
Subject: Re: [patch net-next 01/16] net: introduce upper device lists
Date: Wed, 15 Aug 2012 22:33:56 +0200 [thread overview]
Message-ID: <502C07B4.6050104@gmail.com> (raw)
In-Reply-To: <20120813173110.GA1808@minipsycho.orion>
Le 13/08/2012 19:31, Jiri Pirko a écrit :
> Mon, Aug 13, 2012 at 07:04:11PM CEST, bhutchings@solarflare.com wrote:
>>> +struct netdev_upper {
>>> + struct net_device *dev;
>>> + bool unique;
>>
>> This needs a better name. It doesn't really have anything to do with
>> uniqueness and doesn't ensure exclusivity. I think that it would be
>> fine to keep the 'master' term.
>
> Hmm. I admit that "unique" I do not like too much as well. But "master"
> I like even less.
>
> This flag should ensure exclusivity. Only one upper device with this
> flag can be present at a time.
Well, can't we simply call it "upper_device"?
And as we only have a single field, this is exclusive by design.
Nicolas.
next prev parent reply other threads:[~2012-08-15 20:33 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 15:26 [patch net-next 00/16] net: introduce upper device lists and remove dev->master Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
[not found] ` <1344871635-1052-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-13 15:27 ` [patch net-next 01/16] net: introduce upper device lists Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` Jiri Pirko
2012-08-13 17:04 ` [Bridge] " Ben Hutchings
2012-08-13 17:04 ` Ben Hutchings
2012-08-13 17:04 ` Ben Hutchings
2012-08-13 17:04 ` Ben Hutchings
2012-08-13 17:31 ` Jiri Pirko
2012-08-13 17:31 ` [Bridge] " Jiri Pirko
2012-08-15 20:33 ` Nicolas de Pesloüan [this message]
2012-08-15 20:33 ` Nicolas de Pesloüan
2012-08-15 20:33 ` Nicolas de Pesloüan
2012-08-13 17:52 ` Flavio Leitner
2012-08-13 17:52 ` [Bridge] " Flavio Leitner
2012-08-14 12:24 ` Jiri Pirko
2012-08-14 12:24 ` [Bridge] " Jiri Pirko
2012-08-14 13:14 ` Flavio Leitner
2012-08-14 13:14 ` [Bridge] " Flavio Leitner
2012-08-14 13:35 ` Jiri Pirko
2012-08-14 13:35 ` [Bridge] " Jiri Pirko
2012-08-14 9:02 ` Cong Wang
2012-08-14 9:02 ` Cong Wang
2012-08-14 9:02 ` Cong Wang
2012-08-14 10:18 ` Jiri Pirko
2012-08-14 10:18 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 02/16] macvlan: add link to upper device Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 03/16] vlan: " Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 19:04 ` Flavio Leitner
2012-08-13 19:04 ` [Bridge] " Flavio Leitner
[not found] ` <20120813160421.77a74e4e-8Luz0qD3JK/tRgLqZ5aouw@public.gmane.org>
2012-08-14 7:24 ` Jiri Pirko
2012-08-14 7:24 ` [Bridge] " Jiri Pirko
2012-08-14 7:24 ` Jiri Pirko
2012-08-13 15:27 ` [patch net-next 04/16] rtnetlink: remove usage of dev->master Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 05/16] team: remove usage of netdev_set_master() Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 06/16] bridge: " Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 07/16] netpoll: remove usage of dev->master Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 08/16] cxgb3: " Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 09/16] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 10/16] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 11/16] vlan: remove usage of dev->master in __vlan_find_dev_deep() Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 12/16] nes: remove usage of dev->master Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 13/16] bonding: " Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 14/16] net: remove no longer used netdev_set_bond_master() and netdev_set_master() Jiri Pirko
2012-08-13 15:27 ` [Bridge] " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 15/16] net: remove usage of dev->master Jiri Pirko
2012-08-13 15:28 ` [Bridge] " Jiri Pirko
2012-08-13 17:15 ` Ben Hutchings
2012-08-13 17:15 ` Ben Hutchings
2012-08-13 17:15 ` Ben Hutchings
2012-08-13 17:15 ` Ben Hutchings
[not found] ` <1344878131.2733.28.camel-/LGg1Z1CJKReKY3V0RtoKmatzQS1i7+A3tAM5lWOD0I@public.gmane.org>
2012-08-13 17:31 ` Jiri Pirko
2012-08-13 17:31 ` [Bridge] " Jiri Pirko
2012-08-13 17:31 ` Jiri Pirko
2012-08-13 15:27 ` [patch net-next 16/16] net: kill dev->master Jiri Pirko
2012-08-13 15:28 ` [Bridge] " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502C07B4.6050104@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=blaschka@linux.vnet.ibm.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=edumazet@google.com \
--cc=faisal.latif@intel.com \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=gregory.v.rose@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=jiri@resnulli.us \
--cc=jitendra.kalsaria@qlogic.com \
--cc=joe@perches.com \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=shemminger@vyatta.com \
--cc=sony.chacko@qlogic.com \
--cc=therbert@google.com \
--cc=ursula.braun@de.ibm.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.