Re: [PATCH] gprs: skip CGAUTO for telit

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

Hi Christopher,

On 08/16/2012 04:33 AM, Christopher Vogl wrote:
> Telit does not support +CGAUTO and will just return an error.
> To not confuse people reading the debug output, don't send the command
> for telit.
> ---
>   drivers/atmodem/gprs.c |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index 65a8b7b..4e0823c 100644
> --- a/drivers/atmodem/gprs.c
> +++ b/drivers/atmodem/gprs.c
> @@ -342,7 +342,11 @@ retry:
>   		goto error;
>
>   	g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
> -	g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
> +
> +	if (gd->vendor == OFONO_VENDOR_TELIT)
> +		DBG("Telit does not support +CGAUTO command.");
> +	else
> +		g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);

What are you gaining by printing the above message and not sending the 
CGAUTO?

>
>   	switch (gd->vendor) {
>   	case OFONO_VENDOR_MBM:

Regards,
-Denis