Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master

All of lore.kernel.org
 help / color / mirror / Atom feed

From: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Shubhrajyoti Datta
	<omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
	Thomas Langer
	<thomas.langer-th3ZBGNqt+7QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master
Date: Thu, 16 Aug 2012 11:02:46 +0200	[thread overview]
Message-ID: <502CB736.6010107@openwrt.org> (raw)
In-Reply-To: <CAM=Q2cvCmKMkQjWd0nvuvMMkNt3sH-AcupCq_KzM7EXDuD_-wQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Shubhrajyoti,

Thanks for the comments, I just noticed that clk_put() is also missing
and that the clock gate should be deactivated upon a rmmod ... i will
fix all of these and resend the patch.

John

WARNING: multiple messages have this Message-ID (diff)

From: John Crispin <blogic@openwrt.org>
To: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
	linux-i2c@vger.kernel.org, linux-mips@linux-mips.org,
	Thomas Langer <thomas.langer@lantiq.com>
Subject: Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master
Date: Thu, 16 Aug 2012 11:02:46 +0200	[thread overview]
Message-ID: <502CB736.6010107@openwrt.org> (raw)
In-Reply-To: <CAM=Q2cvCmKMkQjWd0nvuvMMkNt3sH-AcupCq_KzM7EXDuD_-wQ@mail.gmail.com>

Hi Shubhrajyoti,

Thanks for the comments, I just noticed that clk_put() is also missing
and that the clock gate should be deactivated upon a rmmod ... i will
fix all of these and resend the patch.

John

next prev parent reply	other threads:[~2012-08-16  9:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16  7:34 [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master John Crispin
2012-08-16  7:34 ` John Crispin
     [not found] ` <1345102448-4612-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-08-16  8:43   ` Shubhrajyoti Datta
2012-08-16  8:43     ` Shubhrajyoti Datta
     [not found]     ` <CAM=Q2cvCmKMkQjWd0nvuvMMkNt3sH-AcupCq_KzM7EXDuD_-wQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-16  9:02       ` John Crispin [this message]
2012-08-16  9:02         ` John Crispin
     [not found]         ` <502CB736.6010107-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-08-16  9:40           ` Shubhrajyoti Datta
2012-08-16  9:40             ` Shubhrajyoti Datta
  -- strict thread matches above, loose matches on Subject: below --
2011-11-16 14:52 John Crispin
2011-11-16 14:52 ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502CB736.6010107@openwrt.org \
    --to=blogic-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
    --cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=thomas.langer-th3ZBGNqt+7QT0dZR+AlfA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.