Re: [Qemu-devel] [RFC 0/7] Migration stats

[Qunfang Zhang <qzhang@redhat.com>]

Hi, Juan
I have a brief test with these patches applied and it's very useful.  
It's more precise and time-saving than calculate it with some other 
method for the downtime,etc.

Thank you,
Qunfang

On 08/13/2012 06:50 PM, Juan Quintela wrote:
> Hi
>
> This modifies the output of info migrate/qmp_query_migrate to add the
> stats that I got request for.
>
> - It moves total time to MigrationInfo instead of ram (luiz suggestion)
> - Prints the real downtime that we have had
>
>    really, it prints the total downtime of the complete phase, but the
>    downtime also includes the last ram_iterate phase.  Working on
>    fixing that one.
>
> - Prints the expected downtime of the last time that we synchronized
>    the dirty bitmap with kvm.  So we have one idea of what downtime
>    value we need for migration to converge.
>
> - Prints the dirty_pages_rate, that is the number of pages that we
>    have written in the last second.  This one prints always zero.  To
>    fill it, I need the dirty bitmap changes on the migration_thread
>    series.
>
> Patch series apply on top of the migration-next-20120808 series sent
> to anthony.
>
> What do I want to know:
>
> - is there any stat that you want?  Once here, adding a new one should
>    be easy.
>
> - examples are not done, waiting until people agree with what params
>    are needed.
>
> - luiz added in case he has QMP commets.
>
> - erik added for libvirt comments.
>
> Added before is the link to the branch on my repository.
>
> The following changes since commit 346fe0c4c0b88f11a3d0c01c34d9a170d73429cc:
>
>    Merge remote-tracking branch 'stefanha/trivial-patches' into staging (2012-08-11 19:49:03 -0500)
>
> are available in the git repository at:
>
>
>    http://repo.or.cz/r/qemu/quintela.git migration-stats
>
> for you to fetch changes up to e0599012abfc4f9a68185c6f0a10a7b98c0a180f:
>
>    migration: Add dirty_pages_rate to query migrate output (2012-08-13 12:33:35 +0200)
>
> Please review, and comment.
>
> Juan Quintela (7):
>    migration: move total_time from ram stats to migration info
>    migration: store end_time in a local variable
>    migration: print total downtime for final phase of migration
>    migration: rename expected_time to expected_downtime
>    migration: export migration_get_current()
>    migration: print expected downtime in info migrate
>    migration: Add dirty_pages_rate to query migrate output
>
>   arch_init.c      | 19 +++++++++++--------
>   hmp.c            | 16 ++++++++++++++--
>   migration.c      | 19 ++++++++++++++-----
>   migration.h      |  4 ++++
>   qapi-schema.json | 26 +++++++++++++++++++-------
>   5 files changed, 62 insertions(+), 22 deletions(-)
>
>