All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [RFC 0/7] Migration stats
Date: Mon, 13 Aug 2012 17:08:22 +0200	[thread overview]
Message-ID: <87393qygm1.fsf@elfo.mitica> (raw)
In-Reply-To: <50291634.1060407@redhat.com> (Eric Blake's message of "Mon, 13 Aug 2012 08:59:00 -0600")

Eric Blake <eblake@redhat.com> wrote:
> On 08/13/2012 04:50 AM, Juan Quintela wrote:
>> Hi
>> 
>> This modifies the output of info migrate/qmp_query_migrate to add the
>> stats that I got request for.
>> 
>> - It moves total time to MigrationInfo instead of ram (luiz suggestion)
>
> Now's the time to do this, since the stat is new to 1.2 and we haven't
> yet made a release with it.
>
> Should we also rename 'MigrationInfo' to 'MigrationRamInfo', so that we
> don't make a similar mistake in the future of putting a stat in the
> wrong category?

Luiz?  I dont' care one way or the other O:-)

>> What do I want to know:
>> 
>> - is there any stat that you want?  Once here, adding a new one should
>>   be easy.
>
> Should we have some sort of stat for the number of pages that are sent
> more than once, and/or for the maximum count of times that a given page
> was sent?  Having hot/cold page analysis might make it easier to decide
> in the future which pages to avoid sending until the very end, and
> knowing how many pages are sent multiple times as well as the maximum
> times any one page is sent might help.

That is not trivial to do without "duplicating" the bitmap. Bitmap is
already quite big on machines with huge memory.  Adding a field to show
how many times a page have been sent sounds too much.  Furthermore, how
could this information could be used externally.

>> 
>> - examples are not done, waiting until people agree with what params
>>   are needed.
>
> Fair enough for RFC purposes.
>
>> 
>> - luiz added in case he has QMP commets.
>> 
>> - erik added for libvirt comments.
>
> Eric, actually.

Sorry :p

Later, Juan.

  reply	other threads:[~2012-08-13 15:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 10:50 [Qemu-devel] [RFC 0/7] Migration stats Juan Quintela
2012-08-13 10:50 ` [Qemu-devel] [PATCH 1/7] migration: move total_time from ram stats to migration info Juan Quintela
2012-08-13 14:32   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 2/7] migration: store end_time in a local variable Juan Quintela
2012-08-13 15:01   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration Juan Quintela
2012-08-13 15:02   ` Eric Blake
2012-08-13 15:03     ` Eric Blake
2012-08-13 19:36   ` Luiz Capitulino
2012-08-13 10:50 ` [Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime Juan Quintela
2012-08-13 15:05   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 5/7] migration: export migration_get_current() Juan Quintela
2012-08-13 15:06   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate Juan Quintela
2012-08-13 15:08   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output Juan Quintela
2012-08-13 15:12   ` Eric Blake
2012-08-13 16:04     ` Juan Quintela
2012-08-13 16:49       ` Eric Blake
2012-08-13 14:59 ` [Qemu-devel] [RFC 0/7] Migration stats Eric Blake
2012-08-13 15:08   ` Juan Quintela [this message]
2012-08-13 15:14     ` Eric Blake
2012-08-13 19:47   ` Luiz Capitulino
2012-08-16 10:25 ` Qunfang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87393qygm1.fsf@elfo.mitica \
    --to=quintela@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.