From: Avi Kivity <avi@redhat.com>
To: Yin Olivia-R63875 <r63875@freescale.com>
Cc: "blauwirbel@gmail.com" <blauwirbel@gmail.com>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing
Date: Thu, 16 Aug 2012 14:22:31 +0300 [thread overview]
Message-ID: <502CD7F7.1030106@redhat.com> (raw)
In-Reply-To: <B5012D5F6E2BBC4DBF16B3E6037A5B731CD5E8@039-SN1MPN1-004.039d.mgd.msft.net>
On 08/16/2012 02:13 PM, Yin Olivia-R63875 wrote:
> Hi Avi & Ben,
>
> I've got feedback from qemu-ppc list and revised this patch according to Blue's comments.
> Could you please give any comments?
I don't really have any comments, those files are outside my area of
expertise. They look okay to me, but that doesn't mean much as I'm not
familiar with ppc.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-16 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 7:49 [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing Olivia Yin
2012-08-14 7:49 ` [Qemu-devel] [PATCH 2/2] register reset handlers to write images into memory Olivia Yin
2012-08-16 11:13 ` [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing Yin Olivia-R63875
2012-08-16 11:22 ` Avi Kivity [this message]
2012-08-17 9:42 ` Yin Olivia-R63875
2012-08-16 11:36 ` Peter Maydell
2012-08-17 9:40 ` Yin Olivia-R63875
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502CD7F7.1030106@redhat.com \
--to=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=r63875@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.