From: Jiri Slaby <jslaby@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] TTY: tty_alloc_driver() returns error pointers
Date: Thu, 16 Aug 2012 13:56:30 +0000 [thread overview]
Message-ID: <502CFC0E.9020907@suse.cz> (raw)
In-Reply-To: <20120816131656.GB23279@elgon.mountain>
On 08/16/2012 03:16 PM, Dan Carpenter wrote:
> We changed these from alloc_tty_driver() to tty_alloc_driver() so the
> error handling needs to modified to check for IS_ERR() instead of NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Shame.
Acked-by: Jiri Slaby <jslaby@suse.cz>
thanks,
--
js
suse labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jslaby@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] TTY: tty_alloc_driver() returns error pointers
Date: Thu, 16 Aug 2012 15:56:30 +0200 [thread overview]
Message-ID: <502CFC0E.9020907@suse.cz> (raw)
In-Reply-To: <20120816131656.GB23279@elgon.mountain>
On 08/16/2012 03:16 PM, Dan Carpenter wrote:
> We changed these from alloc_tty_driver() to tty_alloc_driver() so the
> error handling needs to modified to check for IS_ERR() instead of NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Shame.
Acked-by: Jiri Slaby <jslaby@suse.cz>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-08-16 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 13:16 [patch] TTY: tty_alloc_driver() returns error pointers Dan Carpenter
2012-08-16 13:16 ` Dan Carpenter
2012-08-16 13:56 ` Jiri Slaby [this message]
2012-08-16 13:56 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502CFC0E.9020907@suse.cz \
--to=jslaby@suse.cz \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.