From: Roland Stigge <stigge@antcom.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@ti.com, gregkh@linuxfoundation.org, arnd@arndb.de,
aletes.xgr@gmail.com, kevin.wells@nxp.com,
srinivas.bakki@nxp.com
Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface
Date: Thu, 16 Aug 2012 18:16:02 +0200 [thread overview]
Message-ID: <502D1CC2.9020901@antcom.de> (raw)
In-Reply-To: <502D1A49.20603@linutronix.de>
On 08/16/2012 06:05 PM, Sebastian Andrzej Siewior wrote:
>> --- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c
>> +++ linux-2.6/drivers/usb/gadget/lpc32xx_udc.c
>> @@ -2987,14 +2986,14 @@ static irqreturn_t lpc32xx_usb_vbus_irq(
>> return IRQ_HANDLED;
>> }
>>
>> -static int lpc32xx_start(struct usb_gadget_driver *driver,
>> - int (*bind)(struct usb_gadget *))
>> +static int lpc32xx_start(struct usb_gadget *gadget,
>> + struct usb_gadget_driver *driver)
>> {
>> - struct lpc32xx_udc *udc =&controller;
>
> I assume controller is a global var created at probe time and could be
> removed now, right?
Yes!
next prev parent reply other threads:[~2012-08-16 16:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 15:34 [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface Roland Stigge
2012-08-16 16:05 ` Sebastian Andrzej Siewior
2012-08-16 16:16 ` Roland Stigge [this message]
2012-08-17 9:10 ` Roland Stigge
2012-08-17 9:42 ` Sebastian Andrzej Siewior
2012-08-17 10:52 ` Felipe Balbi
2012-08-19 12:33 ` Roland Stigge
2012-08-20 7:07 ` Sebastian Andrzej Siewior
2012-08-20 8:11 ` Roland Stigge
2012-08-17 10:51 ` Felipe Balbi
2012-08-17 11:01 ` Sebastian Andrzej Siewior
2012-08-17 11:02 ` Felipe Balbi
2012-08-17 11:28 ` Sebastian Andrzej Siewior
2012-08-17 11:32 ` Roland Stigge
2012-08-17 11:39 ` Sebastian Andrzej Siewior
2012-08-19 12:48 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D1CC2.9020901@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.wells@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.