From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: balbi@ti.com
Cc: Roland Stigge <stigge@antcom.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, arnd@arndb.de, aletes.xgr@gmail.com,
kevin.wells@nxp.com, srinivas.bakki@nxp.com
Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface
Date: Fri, 17 Aug 2012 13:01:44 +0200 [thread overview]
Message-ID: <502E2498.4090106@linutronix.de> (raw)
In-Reply-To: <20120817105103.GE4651@arwen.pp.htv.fi>
On 08/17/2012 12:51 PM, Felipe Balbi wrote:
>> Sounds reasonable?
>
> no it doesn't. Please remove that static global. Sorry but one of the
> goals with udc_start/udc_stop was really to get rid of all those
> nonsensical static globals.
I wouldn't insist on it. If you look at pxa25x, " static struct
pxa25x_udc memory = {" they do the same thing. It is only a simple way
to onetime initialize variables.
Sebastian
next prev parent reply other threads:[~2012-08-17 11:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 15:34 [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface Roland Stigge
2012-08-16 16:05 ` Sebastian Andrzej Siewior
2012-08-16 16:16 ` Roland Stigge
2012-08-17 9:10 ` Roland Stigge
2012-08-17 9:42 ` Sebastian Andrzej Siewior
2012-08-17 10:52 ` Felipe Balbi
2012-08-19 12:33 ` Roland Stigge
2012-08-20 7:07 ` Sebastian Andrzej Siewior
2012-08-20 8:11 ` Roland Stigge
2012-08-17 10:51 ` Felipe Balbi
2012-08-17 11:01 ` Sebastian Andrzej Siewior [this message]
2012-08-17 11:02 ` Felipe Balbi
2012-08-17 11:28 ` Sebastian Andrzej Siewior
2012-08-17 11:32 ` Roland Stigge
2012-08-17 11:39 ` Sebastian Andrzej Siewior
2012-08-19 12:48 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502E2498.4090106@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aletes.xgr@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.wells@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.