From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 10/19] pci-assign: Replace kvm_assign_set_msix_entry with kvm_device_msix_set_vector
Date: Thu, 16 Aug 2012 19:34:18 +0300 [thread overview]
Message-ID: <502D210A.8000800@redhat.com> (raw)
In-Reply-To: <1345134065.4683.471.camel@ul30vt.home>
On 08/16/2012 07:21 PM, Alex Williamson wrote:
>>
>> +int kvm_device_msix_set_vector(KVMState *s, uint32_t dev_id, uint32_t vector,
>> + int virq)
>> +{
>> + struct kvm_assigned_msix_entry msix_entry = {
>> + .assigned_dev_id = dev_id,
>> + .gsi = virq,
>> + .entry = vector,
>> + };
>> +
>> + memset(msix_entry.padding, 0, sizeof(msix_entry.padding));
>
> nit, I think this can be done w/o a memset. .padding = { 0 }? Thanks,
It can be done with a null statement. The msix_entry initialization
above zero-initializes all fields that are not mentioned in the initializer.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-16 18:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 13:54 [PATCH 00/19] pci-assign: Refactor for upstream merge Jan Kiszka
2012-08-16 13:54 ` [PATCH 01/19] pci-assign: Only clean up registered IO resources Jan Kiszka
2012-08-16 13:54 ` [PATCH 02/19] pci-assign: Factor out kvm_device_pci_assign/deassign Jan Kiszka
2012-08-16 13:54 ` [PATCH 03/19] pci-assign: Rename assign_irq to assign_intx Jan Kiszka
2012-08-16 13:54 ` [PATCH 04/19] pci-assign: Refactor interrupt deassignment Jan Kiszka
2012-08-16 13:54 ` [PATCH 05/19] pci-assign: Factor out kvm_device_intx_assign Jan Kiszka
2012-08-16 13:54 ` [PATCH 06/19] qemu-kvm: Move kvm_device_intx_set_mask service Jan Kiszka
2012-08-16 13:54 ` [PATCH 07/19] pci-assign: Rework MSI assignment Jan Kiszka
2012-08-16 13:54 ` [PATCH 08/19] pci-assign: Factor out kvm_device_msix_supported Jan Kiszka
2012-08-16 13:54 ` [PATCH 09/19] pci-assign: Replace kvm_assign_set_msix_nr with kvm_device_msix_init_vectors Jan Kiszka
2012-08-16 13:54 ` [PATCH 10/19] pci-assign: Replace kvm_assign_set_msix_entry with kvm_device_msix_set_vector Jan Kiszka
2012-08-16 16:21 ` Alex Williamson
2012-08-16 16:30 ` Jan Kiszka
2012-08-16 17:30 ` Jan Kiszka
2012-08-16 18:23 ` Alex Williamson
2012-08-16 16:34 ` Avi Kivity [this message]
2012-08-16 16:43 ` Alex Williamson
2012-08-16 13:54 ` [PATCH 11/19] pci-assign: Rework MSI-X route setup Jan Kiszka
2012-08-16 13:54 ` [PATCH 12/19] pci-assign: Factor out kvm_device_msix_assign Jan Kiszka
2012-08-16 13:54 ` [PATCH 13/19] qemu-kvm: Kill qemu-kvm.[ch] Jan Kiszka
2012-08-16 13:54 ` [PATCH 14/19] pci-assign: Drop configure switches Jan Kiszka
2012-08-16 13:54 ` [PATCH 15/19] pci-assign: Move and rename source file Jan Kiszka
2012-08-16 13:54 ` [PATCH 16/19] pci-assign: Fix coding style issues Jan Kiszka
2012-08-16 13:54 ` [PATCH 17/19] pci-assign: Replace exit() with hw_error() Jan Kiszka
2012-08-16 13:54 ` [PATCH 18/19] pci-assign: Drop unused or write-only variables Jan Kiszka
2012-08-16 13:54 ` [PATCH 19/19] pci-assign: Gracefully handle missing in-kernel irqchip support Jan Kiszka
2012-08-16 14:34 ` [PATCH 00/19] pci-assign: Refactor for upstream merge Avi Kivity
2012-08-16 14:49 ` Jan Kiszka
2012-08-16 16:07 ` Michael S. Tsirkin
2012-08-16 16:33 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D210A.8000800@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.