From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 00/19] pci-assign: Refactor for upstream merge
Date: Thu, 16 Aug 2012 19:07:47 +0300 [thread overview]
Message-ID: <20120816160747.GA22494@redhat.com> (raw)
In-Reply-To: <502D050B.9010303@redhat.com>
On Thu, Aug 16, 2012 at 05:34:51PM +0300, Avi Kivity wrote:
> On 08/16/2012 04:54 PM, Jan Kiszka wrote:
> > With this series, we are getting very close to obsoleting qemu-kvm. It
> > refactors hw/device-assignment.c and the associated KVM helper functions
> > into a form that should allow merging them into QEMU. Once the series is
> > acceptable for qemu-kvm, I will break out the necessary uq/master
> > patches and push pci-assign to upstream.
> >
> > The major step of this series is to define a regular set of kvm_device_*
> > services that encapsulate classic (i.e. KVM-based, non-VFIO) device
> > assignment features and export them to i386 targets only. There will
> > never be another arch using them, therefore I pushed them into this
> > corner. Moreover, the device assignment device now makes use of the new
> > KVM IRQ/MSI routing API and no longer pokes into the internals of that
> > layer. Finally, I moved the code into hw/kvm/pci-assign.c, dropped the
> > superfluous configure option and did some basic code cleanups (mostly
> > coding style) to bring things in shape.
> >
> > Note that patch 1 is a simple bug fix that should likely be applied for
> > qemu-kvm-1.2 independently.
> >
> > This series depends on [1] and [2] and QEMU upstream (2b97f88c92) being
> > merged into qemu-kvm.
> >
> > Please review.
>
> >From a quick review it looks ready to merge. Of course I'd appreciate a
> review from Alex or Michael as well.
Looks good to me too.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> --
> error compiling committee.c: too many arguments to function
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-08-16 16:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 13:54 [PATCH 00/19] pci-assign: Refactor for upstream merge Jan Kiszka
2012-08-16 13:54 ` [PATCH 01/19] pci-assign: Only clean up registered IO resources Jan Kiszka
2012-08-16 13:54 ` [PATCH 02/19] pci-assign: Factor out kvm_device_pci_assign/deassign Jan Kiszka
2012-08-16 13:54 ` [PATCH 03/19] pci-assign: Rename assign_irq to assign_intx Jan Kiszka
2012-08-16 13:54 ` [PATCH 04/19] pci-assign: Refactor interrupt deassignment Jan Kiszka
2012-08-16 13:54 ` [PATCH 05/19] pci-assign: Factor out kvm_device_intx_assign Jan Kiszka
2012-08-16 13:54 ` [PATCH 06/19] qemu-kvm: Move kvm_device_intx_set_mask service Jan Kiszka
2012-08-16 13:54 ` [PATCH 07/19] pci-assign: Rework MSI assignment Jan Kiszka
2012-08-16 13:54 ` [PATCH 08/19] pci-assign: Factor out kvm_device_msix_supported Jan Kiszka
2012-08-16 13:54 ` [PATCH 09/19] pci-assign: Replace kvm_assign_set_msix_nr with kvm_device_msix_init_vectors Jan Kiszka
2012-08-16 13:54 ` [PATCH 10/19] pci-assign: Replace kvm_assign_set_msix_entry with kvm_device_msix_set_vector Jan Kiszka
2012-08-16 16:21 ` Alex Williamson
2012-08-16 16:30 ` Jan Kiszka
2012-08-16 17:30 ` Jan Kiszka
2012-08-16 18:23 ` Alex Williamson
2012-08-16 16:34 ` Avi Kivity
2012-08-16 16:43 ` Alex Williamson
2012-08-16 13:54 ` [PATCH 11/19] pci-assign: Rework MSI-X route setup Jan Kiszka
2012-08-16 13:54 ` [PATCH 12/19] pci-assign: Factor out kvm_device_msix_assign Jan Kiszka
2012-08-16 13:54 ` [PATCH 13/19] qemu-kvm: Kill qemu-kvm.[ch] Jan Kiszka
2012-08-16 13:54 ` [PATCH 14/19] pci-assign: Drop configure switches Jan Kiszka
2012-08-16 13:54 ` [PATCH 15/19] pci-assign: Move and rename source file Jan Kiszka
2012-08-16 13:54 ` [PATCH 16/19] pci-assign: Fix coding style issues Jan Kiszka
2012-08-16 13:54 ` [PATCH 17/19] pci-assign: Replace exit() with hw_error() Jan Kiszka
2012-08-16 13:54 ` [PATCH 18/19] pci-assign: Drop unused or write-only variables Jan Kiszka
2012-08-16 13:54 ` [PATCH 19/19] pci-assign: Gracefully handle missing in-kernel irqchip support Jan Kiszka
2012-08-16 14:34 ` [PATCH 00/19] pci-assign: Refactor for upstream merge Avi Kivity
2012-08-16 14:49 ` Jan Kiszka
2012-08-16 16:07 ` Michael S. Tsirkin [this message]
2012-08-16 16:33 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816160747.GA22494@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.