All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
	<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	"ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org"
	<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	"w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: tegra: dynamically control fast clk
Date: Fri, 17 Aug 2012 13:07:50 -0600	[thread overview]
Message-ID: <502E9686.1030209@wwwdotorg.org> (raw)
In-Reply-To: <502E914A.1030906-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 08/17/2012 12:45 PM, Laxman Dewangan wrote:
> On Saturday 18 August 2012 12:11 AM, Stephen Warren wrote:
>> On 08/17/2012 01:48 AM, Laxman Dewangan wrote:
>>> Tegra I2C driver enables the fast clock during initialization
>>> and does not disable till driver removed.
>>> Enable this clock before transfer and disable after transfer done.
>>>
>>> Signed-off-by: Laxman Dewangan<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>> ---
>>> This patch is on top of the clock chnages which is in Tegra sub
>>> system and
>>> based on
>>>   i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20
>>> So recommend to go on tegra sub-system.
>> What exactly is this patch based on? I checked out Tegra's
>> for-3.7/drivers-i2c, cherry-picked the M_NOSTART patch you mentioned,
>> and attempted to apply this patch. It doesn't apply. Same if I don't
>> cherry-pick the M_NOSTART patch, and same for next-20120816 with/without
>> the M_NOSTART patch.
> 
> Then It seems I need to create the patch again and send it.  The
> M_NOSTART patch was on tot before clock related change and that is the
> reason it is not applying.
> Should I re-send these two patches together as 1/2 and 2/2 to maintain
> sequence?
> I can create based on your clock tree.

For any I2C-related changes I take through the Tegra tree, basing them
on top of for-3.7/drivers-i2c would be best. Feel free to send both
patches together again if that's easiest.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
	"ben-linux@fluff.org" <ben-linux@fluff.org>,
	"w.sang@pengutronix.de" <w.sang@pengutronix.de>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] i2c: tegra: dynamically control fast clk
Date: Fri, 17 Aug 2012 13:07:50 -0600	[thread overview]
Message-ID: <502E9686.1030209@wwwdotorg.org> (raw)
In-Reply-To: <502E914A.1030906@nvidia.com>

On 08/17/2012 12:45 PM, Laxman Dewangan wrote:
> On Saturday 18 August 2012 12:11 AM, Stephen Warren wrote:
>> On 08/17/2012 01:48 AM, Laxman Dewangan wrote:
>>> Tegra I2C driver enables the fast clock during initialization
>>> and does not disable till driver removed.
>>> Enable this clock before transfer and disable after transfer done.
>>>
>>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>>> ---
>>> This patch is on top of the clock chnages which is in Tegra sub
>>> system and
>>> based on
>>>   i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20
>>> So recommend to go on tegra sub-system.
>> What exactly is this patch based on? I checked out Tegra's
>> for-3.7/drivers-i2c, cherry-picked the M_NOSTART patch you mentioned,
>> and attempted to apply this patch. It doesn't apply. Same if I don't
>> cherry-pick the M_NOSTART patch, and same for next-20120816 with/without
>> the M_NOSTART patch.
> 
> Then It seems I need to create the patch again and send it.  The
> M_NOSTART patch was on tot before clock related change and that is the
> reason it is not applying.
> Should I re-send these two patches together as 1/2 and 2/2 to maintain
> sequence?
> I can create based on your clock tree.

For any I2C-related changes I take through the Tegra tree, basing them
on top of for-3.7/drivers-i2c would be best. Feel free to send both
patches together again if that's easiest.

  parent reply	other threads:[~2012-08-17 19:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17  7:48 [PATCH] i2c: tegra: dynamically control fast clk Laxman Dewangan
2012-08-17  7:48 ` Laxman Dewangan
     [not found] ` <1345189711-24104-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-17 18:41   ` Stephen Warren
2012-08-17 18:41     ` Stephen Warren
     [not found]     ` <502E9051.4090507-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-17 18:45       ` Laxman Dewangan
2012-08-17 18:45         ` Laxman Dewangan
     [not found]         ` <502E914A.1030906-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-17 19:07           ` Stephen Warren [this message]
2012-08-17 19:07             ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502E9686.1030209@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.