From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio: fix vhost handling
Date: Sat, 18 Aug 2012 20:56:47 +0200 [thread overview]
Message-ID: <502FE56F.9010708@redhat.com> (raw)
In-Reply-To: <502780BB.4000903@msgid.tls.msk.ru>
Il 12/08/2012 12:08, Michael Tokarev ha scritto:
>> > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net
>> > because it always registers the virtio_pci_host_notifier_read() handler
>> > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd.
>> > The result is both QEMU and vhost_net.ko polling on the same eventfd
>> > and the virtio_net.ko guest driver seeing inconsistent results:
>> >
>> > # ifconfig eth0 192.168.0.1 netmask 255.255.255.0
>> > virtio_net virtio0: output:id 0 is not a head!
>> >
>> > To fix this, proceed the same as we do for irqfd: add a parameter to
>> > virtio_queue_set_host_notifier_fd_handler and in that case only set
>> > the notifier, not the handler.
> Stable-1.1 material? The mentioned commit is included into 1.1 release.
Are you sure?
Paolo
next prev parent reply other threads:[~2012-08-18 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 14:56 [Qemu-devel] [PATCH] virtio: fix vhost handling Paolo Bonzini
2012-08-06 15:47 ` Stefan Hajnoczi
2012-08-12 8:58 ` Michael S. Tsirkin
2012-08-12 10:08 ` Michael Tokarev
2012-08-18 18:56 ` Paolo Bonzini [this message]
2012-08-18 18:58 ` Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2012-08-06 13:26 Paolo Bonzini
2012-08-06 13:39 ` Stefan Hajnoczi
2012-08-06 13:51 ` Paolo Bonzini
2012-08-06 20:37 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502FE56F.9010708@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.