Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

[Michael Tokarev <mjt@tls.msk.ru>]

On 18.08.2012 22:56, Paolo Bonzini wrote:
> Il 12/08/2012 12:08, Michael Tokarev ha scritto:
>>>> Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net
>>>> because it always registers the virtio_pci_host_notifier_read() handler
>>>> function on the ioeventfd, even when vhost_net.ko is using the ioeventfd.
>>>> The result is both QEMU and vhost_net.ko polling on the same eventfd
>>>> and the virtio_net.ko guest driver seeing inconsistent results:
>>>>
>>>>   # ifconfig eth0 192.168.0.1 netmask 255.255.255.0
>>>>   virtio_net virtio0: output:id 0 is not a head!
>>>>
>>>> To fix this, proceed the same as we do for irqfd: add a parameter to
>>>> virtio_queue_set_host_notifier_fd_handler and in that case only set
>>>> the notifier, not the handler.
>> Stable-1.1 material?  The mentioned commit is included into 1.1 release.
> 
> Are you sure?

Oh. Indeed. It is 625 commits after 1.1.0 :)  Sorry for the noize.

/mjt