All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Troy Mitchell <troymitchell988@gmail.com>
Cc: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: spacemit: add support for K1 SoC
Date: Mon, 4 Nov 2024 15:48:18 +0100	[thread overview]
Message-ID: <502b0b14-0e1f-4a59-85ad-7edeb9d3033d@kernel.org> (raw)
In-Reply-To: <6cce463e-25cc-4a07-971f-6260347cb581@gmail.com>

On 04/11/2024 14:01, Troy Mitchell wrote:
> 
> On 2024/10/31 16:00, Krzysztof Kozlowski wrote:
>> On Tue, Oct 29, 2024 at 04:36:00PM +0800, Troy Mitchell wrote:
>>> On 2024/10/28 15:38, Krzysztof Kozlowski wrote:
>>>> On Mon, Oct 28, 2024 at 01:32:19PM +0800, Troy Mitchell wrote:
>>>>> The I2C of K1 supports fast-speed-mode and high-speed-mode,
>>>>> and supports FIFO transmission.
>>>>>
>>>>> Signed-off-by: Troy Mitchell <TroyMitchell988@gmail.com>
>>>>> ---
> Change in v2:
>  - Change the maxItems of reg from 1 to 2 in properties

Why?

>  - Change 'i2c' to 'I2C' in the commit message.
>  - Drop fifo-disable property
>  - Drop alias in dts example
>  - Move `unevaluatedProperties` after `required:` block

Rest look ok.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Troy Mitchell <troymitchell988@gmail.com>
Cc: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: spacemit: add support for K1 SoC
Date: Mon, 4 Nov 2024 15:48:18 +0100	[thread overview]
Message-ID: <502b0b14-0e1f-4a59-85ad-7edeb9d3033d@kernel.org> (raw)
In-Reply-To: <6cce463e-25cc-4a07-971f-6260347cb581@gmail.com>

On 04/11/2024 14:01, Troy Mitchell wrote:
> 
> On 2024/10/31 16:00, Krzysztof Kozlowski wrote:
>> On Tue, Oct 29, 2024 at 04:36:00PM +0800, Troy Mitchell wrote:
>>> On 2024/10/28 15:38, Krzysztof Kozlowski wrote:
>>>> On Mon, Oct 28, 2024 at 01:32:19PM +0800, Troy Mitchell wrote:
>>>>> The I2C of K1 supports fast-speed-mode and high-speed-mode,
>>>>> and supports FIFO transmission.
>>>>>
>>>>> Signed-off-by: Troy Mitchell <TroyMitchell988@gmail.com>
>>>>> ---
> Change in v2:
>  - Change the maxItems of reg from 1 to 2 in properties

Why?

>  - Change 'i2c' to 'I2C' in the commit message.
>  - Drop fifo-disable property
>  - Drop alias in dts example
>  - Move `unevaluatedProperties` after `required:` block

Rest look ok.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-11-04 14:48 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28  5:32 [PATCH v2 0/2] riscv: spacemit: add i2c support to K1 SoC Troy Mitchell
2024-10-28  5:32 ` Troy Mitchell
2024-10-28  5:32 ` [PATCH v2 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2024-10-28  5:32   ` Troy Mitchell
2024-10-28  7:38   ` Krzysztof Kozlowski
2024-10-28  7:38     ` Krzysztof Kozlowski
2024-10-29  8:36     ` Troy Mitchell
2024-10-29  8:36       ` Troy Mitchell
2024-10-31  8:00       ` Krzysztof Kozlowski
2024-10-31  8:00         ` Krzysztof Kozlowski
2024-11-01 14:29         ` Jesse T
2024-11-01 14:29           ` Jesse T
2024-11-01 14:37           ` Krzysztof Kozlowski
2024-11-01 14:37             ` Krzysztof Kozlowski
2024-11-04 13:01         ` Troy Mitchell
2024-11-04 13:01           ` Troy Mitchell
2024-11-04 14:48           ` Krzysztof Kozlowski [this message]
2024-11-04 14:48             ` Krzysztof Kozlowski
2024-11-05  1:14             ` Troy Mitchell
2024-11-05  1:14               ` Troy Mitchell
2024-11-05  2:50               ` Samuel Holland
2024-11-05  2:50                 ` Samuel Holland
2024-11-05  5:20                 ` Troy Mitchell
2024-11-05  5:20                   ` Troy Mitchell
2024-10-31  8:01   ` Krzysztof Kozlowski
2024-10-31  8:01     ` Krzysztof Kozlowski
2024-11-02  3:48   ` Samuel Holland
2024-11-02  3:48     ` Samuel Holland
2024-11-06  7:58     ` Troy Mitchell
2024-11-06  7:58       ` Troy Mitchell
2024-11-07  0:29       ` Samuel Holland
2024-11-07  0:29         ` Samuel Holland
2024-11-07  1:57         ` Troy Mitchell
2024-11-07  1:57           ` Troy Mitchell
2024-11-24 19:18         ` Haylen Chu
2024-11-24 19:18           ` Haylen Chu
2024-10-28  5:32 ` [PATCH v2 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2024-10-28  5:32   ` Troy Mitchell
2024-10-28 12:51   ` kernel test robot
2024-10-28 12:51     ` kernel test robot
2024-10-28 14:45   ` kernel test robot
2024-10-28 14:45     ` kernel test robot
2024-11-04 13:01   ` Troy Mitchell
2024-11-04 13:01     ` Troy Mitchell
2024-11-05  6:50   ` Troy Mitchell
2024-11-05  6:50     ` Troy Mitchell
2024-10-31 11:43 ` [PATCH v2 0/2] riscv: spacemit: add i2c support to " Andi Shyti
2024-10-31 11:43   ` Andi Shyti
2024-11-04 12:23   ` Troy Mitchell
2024-11-04 12:23     ` Troy Mitchell
2024-11-05 14:21     ` Andi Shyti
2024-11-05 14:21       ` Andi Shyti
2024-11-06  7:59       ` Troy Mitchell
2024-11-06  7:59         ` Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502b0b14-0e1f-4a59-85ad-7edeb9d3033d@kernel.org \
    --to=krzk@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=troymitchell988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.