* [PATCH] omap-mcbsp: properly check for availablity of mcbsp mux settings
@ 2012-08-19 19:14 Andreas Kemnade
2012-08-20 6:02 ` Jarkko Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2012-08-19 19:14 UTC (permalink / raw)
To: peter.ujfalusi, jarkko.nikula, linux-omap; +Cc: Andreas Kemnade
The code did return -EINVAl when the mux_signal function pointer is available.
If not, the corresponding function (the NULL pointer) is called.
This patch inverts that logic.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
sound/soc/omap/mcbsp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 34835e8..d33c48b 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -745,7 +745,7 @@ int omap_mcbsp_6pin_src_mux(struct omap_mcbsp *mcbsp, u8 mux)
{
const char *signal, *src;
- if (mcbsp->pdata->mux_signal)
+ if (!mcbsp->pdata->mux_signal)
return -EINVAL;
switch (mux) {
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omap-mcbsp: properly check for availablity of mcbsp mux settings
2012-08-19 19:14 [PATCH] omap-mcbsp: properly check for availablity of mcbsp mux settings Andreas Kemnade
@ 2012-08-20 6:02 ` Jarkko Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Nikula @ 2012-08-20 6:02 UTC (permalink / raw)
To: Andreas Kemnade; +Cc: peter.ujfalusi, linux-omap
Hi
On 08/19/2012 10:14 PM, Andreas Kemnade wrote:
> The code did return -EINVAl when the mux_signal function pointer is available.
> If not, the corresponding function (the NULL pointer) is called.
> This patch inverts that logic.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
Thanks for the patch. Fortunately Peter has already the same fix d0db84e
(ASoC: omap-mcbsp: Fix 6pin mux configuration) for it in:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
I expect fix to hit 3.6-rc and 3.4-3.5 stable soon.
--
Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-20 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-19 19:14 [PATCH] omap-mcbsp: properly check for availablity of mcbsp mux settings Andreas Kemnade
2012-08-20 6:02 ` Jarkko Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.