All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: Rob Herring <robherring2@gmail.com>
Cc: Alexandre Pereira da Silva <aletes.xgr@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Landley <rob@landley.net>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	"Mark Brown (broonie@opensource.wolfsonmicro.com)"
	<broonie@opensource.wolfsonmicro.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH RESEND v4] spi/pl022: add devicetree support
Date: Mon, 20 Aug 2012 17:33:34 +0200	[thread overview]
Message-ID: <503258CE.9030106@antcom.de> (raw)
In-Reply-To: <50324835.6030806@gmail.com>

On 08/20/2012 04:22 PM, Rob Herring wrote:
>>  .../devicetree/bindings/spi/spi_pl022.txt          |   15 +++
>>  drivers/spi/spi-pl022.c                            |  114 ++++++++++++++++----
>>  2 files changed, 110 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
>> index 306ec3f..b089ec7 100644
>> --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
>> @@ -6,7 +6,22 @@ Required properties:
>>  - interrupts : Should contain SPI controller interrupt
>>  
>>  Optional properties:
>> +- pl022,num-chipselects : total number of chipselects
> 
> We have this for other spi controllers too. Define a generic property.

Currently, we have:

num-cs
ti,spi-num-cs
fsl,spi-num-chipselects
fsl,espi-num-chipselects
(pl022,num-chipselects)

Would "num-cs" be the right one to use?

Thanks,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Rob Herring <robherring2@gmail.com>
Cc: Alexandre Pereira da Silva <aletes.xgr@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Landley <rob@landley.net>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	"Mark Brown (broonie@opensource.wolfsonmicro.com)"
	<broonie@opensource.wolfsonmicro.com>,
	Linus Walleij
	<linus.walleij@linaro.org>devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH RESEND v4] spi/pl022: add devicetree support
Date: Mon, 20 Aug 2012 17:33:34 +0200	[thread overview]
Message-ID: <503258CE.9030106@antcom.de> (raw)
In-Reply-To: <50324835.6030806@gmail.com>

On 08/20/2012 04:22 PM, Rob Herring wrote:
>>  .../devicetree/bindings/spi/spi_pl022.txt          |   15 +++
>>  drivers/spi/spi-pl022.c                            |  114 ++++++++++++++++----
>>  2 files changed, 110 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
>> index 306ec3f..b089ec7 100644
>> --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
>> @@ -6,7 +6,22 @@ Required properties:
>>  - interrupts : Should contain SPI controller interrupt
>>  
>>  Optional properties:
>> +- pl022,num-chipselects : total number of chipselects
> 
> We have this for other spi controllers too. Define a generic property.

Currently, we have:

num-cs
ti,spi-num-cs
fsl,spi-num-chipselects
fsl,espi-num-chipselects
(pl022,num-chipselects)

Would "num-cs" be the right one to use?

Thanks,

Roland

  parent reply	other threads:[~2012-08-20 15:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 11:39 [PATCH RESEND v4] spi/pl022: add devicetree support Alexandre Pereira da Silva
2012-08-20 11:39 ` Alexandre Pereira da Silva
2012-08-20 12:58 ` Roland Stigge
     [not found]   ` <50323464.4070006-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-08-20 13:07     ` Rob Herring
2012-08-20 13:07       ` Rob Herring
2012-08-20 13:07       ` Rob Herring
2012-08-20 14:22 ` Rob Herring
2012-08-20 15:09   ` Linus Walleij
2012-08-20 15:33   ` Roland Stigge [this message]
2012-08-20 15:33     ` Roland Stigge
2012-08-20 15:53     ` Rob Herring
2012-08-20 15:02 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503258CE.9030106@antcom.de \
    --to=stigge@antcom.de \
    --cc=aletes.xgr@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=robherring2@gmail.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.