From: Richard Weinberger <richard@nod.at>
To: Sage Weil <sage@inktank.com>
Cc: jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] build error on 3.6-rc1 and later
Date: Mon, 20 Aug 2012 18:52:52 +0200 [thread overview]
Message-ID: <50326B64.7020904@nod.at> (raw)
In-Reply-To: <alpine.DEB.2.00.1208200947470.9242@cobra.newdream.net>
[-- Attachment #1.1: Type: text/plain, Size: 1002 bytes --]
Am 20.08.2012 18:49, schrieb Sage Weil:
> I'm getting
>
> arch/um/os-Linux/time.c: In function 'deliver_alarm':
> arch/um/os-Linux/time.c:117:3: error: too few arguments to function 'alarm_handler'
> In file included from arch/um/os-Linux/time.c:13:0:
> arch/um/os-Linux/internal.h:1:6: note: declared here
>
> on 3.6-rc1 and later. FWIW I blindly added an extra NULL argument and it
> seems to behave:
>
> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
> index f602385..0748fe0 100644
> --- a/arch/um/os-Linux/time.c
> +++ b/arch/um/os-Linux/time.c
> @@ -114,7 +114,7 @@ static void deliver_alarm(void)
> skew += this_tick - last_tick;
>
> while (skew >= one_tick) {
> - alarm_handler(SIGVTALRM, NULL);
> + alarm_handler(SIGVTALRM, NULL, NULL);
> skew -= one_tick;
> }
>
Martin,
looks like you've introduced this regression.
Can you please have a look?
Thanks,
//richard
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 395 bytes --]
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
[-- Attachment #3: Type: text/plain, Size: 194 bytes --]
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2012-08-20 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 16:49 [uml-devel] build error on 3.6-rc1 and later Sage Weil
2012-08-20 16:52 ` Richard Weinberger [this message]
2012-08-20 19:59 ` Martin Pärtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50326B64.7020904@nod.at \
--to=richard@nod.at \
--cc=jdike@addtoit.com \
--cc=sage@inktank.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.