[uml-devel] build error on 3.6-rc1 and later

[uml-devel] build error on 3.6-rc1 and later

[Sage Weil]

I'm getting

arch/um/os-Linux/time.c: In function 'deliver_alarm':
arch/um/os-Linux/time.c:117:3: error: too few arguments to function 'alarm_handler'
In file included from arch/um/os-Linux/time.c:13:0:
arch/um/os-Linux/internal.h:1:6: note: declared here

on 3.6-rc1 and later.  FWIW I blindly added an extra NULL argument and it 
seems to behave:

diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
index f602385..0748fe0 100644
--- a/arch/um/os-Linux/time.c
+++ b/arch/um/os-Linux/time.c
@@ -114,7 +114,7 @@ static void deliver_alarm(void)
        skew += this_tick - last_tick;
 
        while (skew >= one_tick) {
-               alarm_handler(SIGVTALRM, NULL);
+               alarm_handler(SIGVTALRM, NULL, NULL);
                skew -= one_tick;
        }
 
sage

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] build error on 3.6-rc1 and later

[Richard Weinberger]

[-- Attachment #1.1: Type: text/plain, Size: 1002 bytes --]

Am 20.08.2012 18:49, schrieb Sage Weil:
> I'm getting
> 
> arch/um/os-Linux/time.c: In function 'deliver_alarm':
> arch/um/os-Linux/time.c:117:3: error: too few arguments to function 'alarm_handler'
> In file included from arch/um/os-Linux/time.c:13:0:
> arch/um/os-Linux/internal.h:1:6: note: declared here
> 
> on 3.6-rc1 and later.  FWIW I blindly added an extra NULL argument and it 
> seems to behave:
> 
> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
> index f602385..0748fe0 100644
> --- a/arch/um/os-Linux/time.c
> +++ b/arch/um/os-Linux/time.c
> @@ -114,7 +114,7 @@ static void deliver_alarm(void)
>         skew += this_tick - last_tick;
>  
>         while (skew >= one_tick) {
> -               alarm_handler(SIGVTALRM, NULL);
> +               alarm_handler(SIGVTALRM, NULL, NULL);
>                 skew -= one_tick;
>         }
>  

Martin,

looks like you've introduced this regression.
Can you please have a look?

Thanks,
//richard


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #3: Type: text/plain, Size: 194 bytes --]

_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] build error on 3.6-rc1 and later

[Martin Pärtel]

Darn, sorry! I should have tried to compile under different 
configurations. Adding the NULL is the correct fix.

On 08/20/2012 07:52 PM, Richard Weinberger wrote:
> Am 20.08.2012 18:49, schrieb Sage Weil:
>> I'm getting
>>
>> arch/um/os-Linux/time.c: In function 'deliver_alarm':
>> arch/um/os-Linux/time.c:117:3: error: too few arguments to function 'alarm_handler'
>> In file included from arch/um/os-Linux/time.c:13:0:
>> arch/um/os-Linux/internal.h:1:6: note: declared here
>>
>> on 3.6-rc1 and later.  FWIW I blindly added an extra NULL argument and it
>> seems to behave:
>>
>> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
>> index f602385..0748fe0 100644
>> --- a/arch/um/os-Linux/time.c
>> +++ b/arch/um/os-Linux/time.c
>> @@ -114,7 +114,7 @@ static void deliver_alarm(void)
>>          skew += this_tick - last_tick;
>>
>>          while (skew >= one_tick) {
>> -               alarm_handler(SIGVTALRM, NULL);
>> +               alarm_handler(SIGVTALRM, NULL, NULL);
>>                  skew -= one_tick;
>>          }
>>
>
> Martin,
>
> looks like you've introduced this regression.
> Can you please have a look?
>
> Thanks,
> //richard
>


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel