[Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-response field in guest-info

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On 08/21/2012 06:03 AM, Michal Privoznik wrote:
> This is a useful hint for users (or libvirt) whether a command returns
> anything success and hence wait for reply or not.
> ---
> diff to v1:
> -changed condition in qmp_command_reports_success per Paolo's advice
> 
>  qapi-schema-guest.json |    6 +++++-
>  qapi/qmp-core.h        |    1 +
>  qapi/qmp-registry.c    |   12 ++++++++++++
>  qga/commands.c         |    1 +
>  4 files changed, 19 insertions(+), 1 deletions(-)

Adding 'For 1.2', on the grounds that we changed semantics in 1.2 (1.1
didn't have any commands with success-response marking to begin with),
and therefore it is a usability bug if we don't fix it in time for this
release.

> 
> diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json
> index d955cf1..2cd5957 100644
> --- a/qapi-schema-guest.json
> +++ b/qapi-schema-guest.json
> @@ -91,10 +91,14 @@
>  #
>  # @enabled: whether command is currently enabled by guest admin
>  #
> +# @success-response: whether command report success response or not.
> +#                    See 'uest-shutdown' command for more detailed info.

s/uest/guest/

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]