From: Eric Blake <eblake@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-response field in guest-info
Date: Tue, 21 Aug 2012 06:29:28 -0600 [thread overview]
Message-ID: <50337F28.1080704@redhat.com> (raw)
In-Reply-To: <50337C3D.7020705@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On 08/21/2012 06:17 AM, Eric Blake wrote:
> On 08/21/2012 06:03 AM, Michal Privoznik wrote:
>> This is a useful hint for users (or libvirt) whether a command returns
>> anything success and hence wait for reply or not.
>> +++ b/qapi-schema-guest.json
>> @@ -91,10 +91,14 @@
>> #
>> # @enabled: whether command is currently enabled by guest admin
>> #
>> +# @success-response: whether command report success response or not.
This sentence is also awkward. I suggest something like:
true unless the command does not respond on success
>> +# See 'uest-shutdown' command for more detailed info.
>
> s/uest/guest/
>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
prev parent reply other threads:[~2012-08-21 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 12:03 [Qemu-devel] [PATCH v2] qemu-ga: report success-response field in guest-info Michal Privoznik
2012-08-21 12:17 ` [Qemu-devel] For 1.2: " Eric Blake
2012-08-21 12:29 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50337F28.1080704@redhat.com \
--to=eblake@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.