From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: AnilKumar Ch <anilkumar@ti.com>,
tony@atomide.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] arm/dts: regulator: Add tps65910 device tree data
Date: Tue, 21 Aug 2012 12:05:15 -0600 [thread overview]
Message-ID: <5033CDDB.808@wwwdotorg.org> (raw)
In-Reply-To: <20120821163805.GW7995@opensource.wolfsonmicro.com>
On 08/21/2012 10:38 AM, Mark Brown wrote:
> On Tue, Aug 21, 2012 at 09:48:21AM -0600, Stephen Warren wrote:
>
>> This .dtsi file adds a node for every single regulator within
>> the TPS65910, which in turn means that of_regulator_match() will
>> find a node for every regulator, and in turn every regulator will
>> be registered. On some boards, not all of those regulators will
>> be used, and hence we don't want all of them to be registered.
>
> This isn't the general view for the regualtor API - we generally
> want all regulators to be registered in order to allow us to see
> what's going on with things even if we've not figured them out from
> software.
Oh, I said the above specifically because when I added the LDO
configuration for the regulators that weren't used to the Tegra .dts
files, you told me to remove it, based on the comment I put in there
that they weren't used on the board.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] arm/dts: regulator: Add tps65910 device tree data
Date: Tue, 21 Aug 2012 12:05:15 -0600 [thread overview]
Message-ID: <5033CDDB.808@wwwdotorg.org> (raw)
In-Reply-To: <20120821163805.GW7995@opensource.wolfsonmicro.com>
On 08/21/2012 10:38 AM, Mark Brown wrote:
> On Tue, Aug 21, 2012 at 09:48:21AM -0600, Stephen Warren wrote:
>
>> This .dtsi file adds a node for every single regulator within
>> the TPS65910, which in turn means that of_regulator_match() will
>> find a node for every regulator, and in turn every regulator will
>> be registered. On some boards, not all of those regulators will
>> be used, and hence we don't want all of them to be registered.
>
> This isn't the general view for the regualtor API - we generally
> want all regulators to be registered in order to allow us to see
> what's going on with things even if we've not figured them out from
> software.
Oh, I said the above specifically because when I added the LDO
configuration for the regulators that weren't used to the Tegra .dts
files, you told me to remove it, based on the comment I put in there
that they weren't used on the board.
next prev parent reply other threads:[~2012-08-21 18:05 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 11:17 [PATCH v3 0/4] Add AM33XX regulators device tree data AnilKumar Ch
2012-08-21 11:17 ` AnilKumar Ch
2012-08-21 11:17 ` [PATCH v3 1/4] arm/dts: regulator: Add tps65910 " AnilKumar Ch
2012-08-21 11:17 ` AnilKumar Ch
2012-08-21 15:48 ` Stephen Warren
2012-08-21 15:48 ` Stephen Warren
2012-08-21 16:38 ` Mark Brown
2012-08-21 16:38 ` Mark Brown
2012-08-21 18:05 ` Stephen Warren [this message]
2012-08-21 18:05 ` Stephen Warren
2012-08-21 18:08 ` Mark Brown
2012-08-21 18:08 ` Mark Brown
2012-08-24 20:16 ` Tony Lindgren
2012-08-24 20:16 ` Tony Lindgren
2012-08-27 16:51 ` Mark Brown
2012-08-27 16:51 ` Mark Brown
2012-08-21 11:17 ` [PATCH v3 2/4] arm/dts: regulator: Add tps65217 " AnilKumar Ch
2012-08-21 11:17 ` AnilKumar Ch
2012-08-21 11:17 ` [PATCH v3 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts AnilKumar Ch
2012-08-21 11:17 ` AnilKumar Ch
2012-08-21 11:17 ` [PATCH v3 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts AnilKumar Ch
2012-08-21 11:17 ` AnilKumar Ch
2012-08-23 14:13 ` Koen Kooi
2012-08-23 14:13 ` Koen Kooi
2012-08-24 5:50 ` AnilKumar, Chimata
2012-08-24 5:50 ` AnilKumar, Chimata
2012-08-24 6:28 ` Koen Kooi
2012-08-24 6:28 ` Koen Kooi
2012-08-24 7:26 ` AnilKumar, Chimata
2012-08-24 7:26 ` AnilKumar, Chimata
2012-08-24 7:56 ` Koen Kooi
2012-08-24 7:56 ` Koen Kooi
2012-08-24 8:02 ` Koen Kooi
2012-08-24 8:02 ` Koen Kooi
2012-08-28 5:34 ` AnilKumar, Chimata
2012-08-28 5:34 ` AnilKumar, Chimata
2012-09-05 13:29 ` Koen Kooi
2012-09-05 13:29 ` Koen Kooi
2012-09-05 14:24 ` Matt Porter
2012-09-05 14:24 ` Matt Porter
2012-09-05 14:29 ` Koen Kooi
2012-09-05 14:29 ` Koen Kooi
2012-09-08 6:38 ` AnilKumar, Chimata
2012-09-08 6:38 ` AnilKumar, Chimata
2012-09-10 16:26 ` Matt Porter
2012-09-10 16:26 ` Matt Porter
2012-08-21 13:57 ` [PATCH v3 0/4] Add AM33XX regulators device tree data Mark Brown
2012-08-21 13:57 ` Mark Brown
2012-08-30 21:01 ` Tony Lindgren
2012-08-30 21:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033CDDB.808@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=anilkumar@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.