From: Avi Kivity <avi@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com,
kraxel@redhat.com, xen-devel@lists.xensource.com,
i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com,
anthony.perard@citrix.com, lersek@redhat.com,
stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com,
sw@weilnetz.de, imammedo@redhat.com, lcapitulino@redhat.com,
rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com,
mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC 0/8] include qdev core in *-user, make CPU child of DeviceState
Date: Wed, 22 Aug 2012 12:05:44 +0300 [thread overview]
Message-ID: <5034A0E8.1080507@redhat.com> (raw)
In-Reply-To: <1345563782-11224-1-git-send-email-ehabkost@redhat.com>
On 08/21/2012 06:42 PM, Eduardo Habkost wrote:
> So, here's a third suggestion to the CPU/DeviceState problem. Basically I split
> the qdev code into a core (that can be easily compiled into *-user), and a part
> specific to qemu-system-*.
>
I'm barging in late here, so sorry if this has been suggested and shot
down: is it not possible to use composition here?
typedef ... CPU;
typedef struct CPUState {
DeviceState qdev;
CPU cpu;
} CPUState;
But I guess bringing qdev to -user is inevitable.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com,
kraxel@redhat.com, xen-devel@lists.xensource.com,
i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com,
anthony.perard@citrix.com, lersek@redhat.com,
stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com,
sw@weilnetz.de, imammedo@redhat.com, lcapitulino@redhat.com,
rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com,
mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [RFC 0/8] include qdev core in *-user, make CPU child of DeviceState
Date: Wed, 22 Aug 2012 12:05:44 +0300 [thread overview]
Message-ID: <5034A0E8.1080507@redhat.com> (raw)
In-Reply-To: <1345563782-11224-1-git-send-email-ehabkost@redhat.com>
On 08/21/2012 06:42 PM, Eduardo Habkost wrote:
> So, here's a third suggestion to the CPU/DeviceState problem. Basically I split
> the qdev code into a core (that can be easily compiled into *-user), and a part
> specific to qemu-system-*.
>
I'm barging in late here, so sorry if this has been suggested and shot
down: is it not possible to use composition here?
typedef ... CPU;
typedef struct CPUState {
DeviceState qdev;
CPU cpu;
} CPUState;
But I guess bringing qdev to -user is inevitable.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-22 9:06 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 15:42 [Qemu-devel] [RFC 0/8] include qdev core in *-user, make CPU child of DeviceState Eduardo Habkost
2012-08-21 15:42 ` Eduardo Habkost
2012-08-21 15:42 ` [Qemu-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h Eduardo Habkost
2012-08-21 15:42 ` Eduardo Habkost
2012-08-21 16:10 ` [Qemu-devel] " Peter Maydell
2012-08-21 16:10 ` Peter Maydell
2012-08-27 14:28 ` [Qemu-devel] " Igor Mammedov
2012-08-27 14:28 ` Igor Mammedov
2012-08-29 15:36 ` [Qemu-devel] [Xen-devel] " Igor Mammedov
2012-08-29 15:36 ` Igor Mammedov
2012-08-29 15:38 ` [Qemu-devel] " Peter Maydell
2012-08-29 15:38 ` Peter Maydell
2012-08-21 15:42 ` [Qemu-devel] [RFC 2/8] qdev: split up header so it can be used in cpu.h Eduardo Habkost
2012-08-21 15:42 ` Eduardo Habkost
2012-08-21 15:42 ` [Qemu-devel] [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h Eduardo Habkost
2012-08-21 15:42 ` Eduardo Habkost
2012-08-21 18:21 ` [Qemu-devel] " Luiz Capitulino
2012-08-21 18:21 ` Luiz Capitulino
2012-08-21 15:42 ` [Qemu-devel] [RFC 4/8] cleanup error.h, included qapi-types.h aready has stdbool.h Eduardo Habkost
2012-08-21 15:42 ` Eduardo Habkost
2012-08-21 16:45 ` [Qemu-devel] " Peter Maydell
2012-08-21 16:45 ` Peter Maydell
2012-08-21 16:53 ` [Qemu-devel] " Eduardo Habkost
2012-08-21 16:53 ` Eduardo Habkost
2012-08-21 15:42 ` [Qemu-devel] [RFC 5/8] split qdev into a core and code used only by qemu-system-* Eduardo Habkost
2012-08-21 15:42 ` Eduardo Habkost
2012-08-21 18:44 ` [Qemu-devel] " Blue Swirl
2012-08-21 18:44 ` Blue Swirl
2012-08-21 15:43 ` [Qemu-devel] [RFC 6/8] qdev: use full qdev.h include path on qdev*.c Eduardo Habkost
2012-08-21 15:43 ` Eduardo Habkost
2012-08-21 16:29 ` [Qemu-devel] " Peter Maydell
2012-08-21 16:29 ` Peter Maydell
2012-08-21 18:25 ` [Qemu-devel] " Eduardo Habkost
2012-08-21 18:25 ` Eduardo Habkost
2012-08-21 15:43 ` [Qemu-devel] [RFC 7/8] include core qdev code into *-user, too Eduardo Habkost
2012-08-21 15:43 ` Eduardo Habkost
2012-08-21 16:59 ` [Qemu-devel] " Peter Maydell
2012-08-21 16:59 ` Peter Maydell
2012-08-21 18:55 ` [Qemu-devel] " Eduardo Habkost
2012-08-21 18:55 ` Eduardo Habkost
2012-08-21 15:43 ` [Qemu-devel] [RFC 8/8] make CPU a child of DeviceState Eduardo Habkost
2012-08-21 15:43 ` Eduardo Habkost
2012-08-22 9:05 ` Avi Kivity [this message]
2012-08-22 9:05 ` [RFC 0/8] include qdev core in *-user, make CPU " Avi Kivity
2012-08-22 13:08 ` [Qemu-devel] " Eduardo Habkost
2012-08-22 13:08 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5034A0E8.1080507@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=i.mitsyanko@samsung.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@linux.vnet.ibm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.