* [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings
@ 2012-08-22 19:40 Stefan Weil
2012-08-22 19:45 ` Stefan Weil
2012-09-22 21:22 ` Stefan Weil
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2012-08-22 19:40 UTC (permalink / raw)
To: qemu-trivial; +Cc: Blue Swirl, Stefan Weil
GLib 2.0 include files use __printf__ for the format attribute
which resolves to native format strings on w32 hosts.
QEMU wants standard format strings instead of native format
strings, so we simply change any declaration with __printf__
to use __gnu_printf__.
This works because all basic printf functions support both
kinds of format strings.
This fixes a compiler warning:
qapi/string-output-visitor.c: In function ‘print_type_int’:
qapi/string-output-visitor.c:34:5: warning: unknown conversion type character ‘l’ in format [-Wformat]
qapi/string-output-visitor.c:34:5: warning: too many arguments for format [-Wformat-extra-args]
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
compiler.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/compiler.h b/compiler.h
index 07ba1f8..c734a71 100644
--- a/compiler.h
+++ b/compiler.h
@@ -44,6 +44,11 @@
/* Use gnu_printf when supported (qemu uses standard format strings). */
# define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2)))
# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
+# if defined(_WIN32)
+ /* Map __printf__ to __gnu_printf__ because we want standard format strings
+ * even when MinGW or GLib include files use __printf__. */
+# define __printf__ __gnu_printf__
+# endif
# endif
#if defined(_WIN32)
#define GCC_WEAK __attribute__((weak))
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings
2012-08-22 19:40 [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings Stefan Weil
@ 2012-08-22 19:45 ` Stefan Weil
2012-08-24 11:23 ` Stefan Hajnoczi
2012-09-22 21:22 ` Stefan Weil
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2012-08-22 19:45 UTC (permalink / raw)
To: qemu-trivial; +Cc: Blue Swirl
Am 22.08.2012 21:40, schrieb Stefan Weil:
> GLib 2.0 include files use __printf__ for the format attribute
> which resolves to native format strings on w32 hosts.
>
> QEMU wants standard format strings instead of native format
> strings, so we simply change any declaration with __printf__
> to use __gnu_printf__.
>
> This works because all basic printf functions support both
> kinds of format strings.
>
> This fixes a compiler warning:
>
> qapi/string-output-visitor.c: In function ‘print_type_int’:
> qapi/string-output-visitor.c:34:5: warning: unknown conversion type
> character ‘l’ in format [-Wformat]
> qapi/string-output-visitor.c:34:5: warning: too many arguments for
> format [-Wformat-extra-args]
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> compiler.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/compiler.h b/compiler.h
> index 07ba1f8..c734a71 100644
> --- a/compiler.h
> +++ b/compiler.h
> @@ -44,6 +44,11 @@
> /* Use gnu_printf when supported (qemu uses standard format strings). */
> # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2)))
> # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
> +# if defined(_WIN32)
> + /* Map __printf__ to __gnu_printf__ because we want standard format
> strings
> + * even when MinGW or GLib include files use __printf__. */
> +# define __printf__ __gnu_printf__
> +# endif
> # endif
> #if defined(_WIN32)
> #define GCC_WEAK __attribute__((weak))
Sorry, I used the wrong mail address.
The mail should go to qemu-devel, not to qemu-trivial.
Of course I don't mind if it is applied via qemu-trivial.
Cheers,
Stefan W.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings
2012-08-22 19:45 ` Stefan Weil
@ 2012-08-24 11:23 ` Stefan Hajnoczi
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2012-08-24 11:23 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Blue Swirl
On Wed, Aug 22, 2012 at 09:45:31PM +0200, Stefan Weil wrote:
> Am 22.08.2012 21:40, schrieb Stefan Weil:
> >GLib 2.0 include files use __printf__ for the format attribute
> >which resolves to native format strings on w32 hosts.
> >
> >QEMU wants standard format strings instead of native format
> >strings, so we simply change any declaration with __printf__
> >to use __gnu_printf__.
> >
> >This works because all basic printf functions support both
> >kinds of format strings.
> >
> >This fixes a compiler warning:
> >
> >qapi/string-output-visitor.c: In function ‘print_type_int’:
> >qapi/string-output-visitor.c:34:5: warning: unknown conversion
> >type character ‘l’ in format [-Wformat]
> >qapi/string-output-visitor.c:34:5: warning: too many arguments for
> >format [-Wformat-extra-args]
> >
> >Signed-off-by: Stefan Weil <sw@weilnetz.de>
> >---
> >compiler.h | 5 +++++
> >1 file changed, 5 insertions(+)
> >
> >diff --git a/compiler.h b/compiler.h
> >index 07ba1f8..c734a71 100644
> >--- a/compiler.h
> >+++ b/compiler.h
> >@@ -44,6 +44,11 @@
> >/* Use gnu_printf when supported (qemu uses standard format strings). */
> ># define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2)))
> ># define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
> >+# if defined(_WIN32)
> >+ /* Map __printf__ to __gnu_printf__ because we want standard
> >format strings
> >+ * even when MinGW or GLib include files use __printf__. */
> >+# define __printf__ __gnu_printf__
> >+# endif
> ># endif
> >#if defined(_WIN32)
> >#define GCC_WEAK __attribute__((weak))
>
> Sorry, I used the wrong mail address.
> The mail should go to qemu-devel, not to qemu-trivial.
Okay, not applying.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings
2012-08-22 19:40 [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings Stefan Weil
2012-08-22 19:45 ` Stefan Weil
@ 2012-09-22 21:22 ` Stefan Weil
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2012-09-22 21:22 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-trivial
Am 22.08.2012 21:40, schrieb Stefan Weil:
> GLib 2.0 include files use __printf__ for the format attribute
> which resolves to native format strings on w32 hosts.
>
> QEMU wants standard format strings instead of native format
> strings, so we simply change any declaration with __printf__
> to use __gnu_printf__.
>
> This works because all basic printf functions support both
> kinds of format strings.
>
> This fixes a compiler warning:
>
> qapi/string-output-visitor.c: In function ‘print_type_int’:
> qapi/string-output-visitor.c:34:5: warning: unknown conversion type character ‘l’ in format [-Wformat]
> qapi/string-output-visitor.c:34:5: warning: too many arguments for format [-Wformat-extra-args]
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
> compiler.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/compiler.h b/compiler.h
> index 07ba1f8..c734a71 100644
> --- a/compiler.h
> +++ b/compiler.h
> @@ -44,6 +44,11 @@
> /* Use gnu_printf when supported (qemu uses standard format strings). */
> # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2)))
> # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
> +# if defined(_WIN32)
> + /* Map __printf__ to __gnu_printf__ because we want standard format strings
> + * even when MinGW or GLib include files use __printf__. */
> +# define __printf__ __gnu_printf__
> +# endif
> # endif
> #if defined(_WIN32)
> #define GCC_WEAK __attribute__((weak))
>
Ping? Should I send a pull request?
Stefan W.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-22 21:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 19:40 [Qemu-trivial] [PATCH] w32: Always use standard instead of native format strings Stefan Weil
2012-08-22 19:45 ` Stefan Weil
2012-08-24 11:23 ` Stefan Hajnoczi
2012-09-22 21:22 ` Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.