From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register
Date: Wed, 22 Aug 2012 23:21:03 -0600 [thread overview]
Message-ID: <5035BDBF.9020602@wwwdotorg.org> (raw)
In-Reply-To: <1345619928-15446-5-git-send-email-b29396@freescale.com>
On 08/22/2012 01:18 AM, Dong Aisheng wrote:
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c
> @@ -109,7 +110,11 @@ static int __devinit anatop_regulator_probe(struct platform_device *pdev)
> rdesc->ops = &anatop_rops;
> rdesc->type = REGULATOR_VOLTAGE;
> rdesc->owner = THIS_MODULE;
> - sreg->mfd = anatopmfd;
> +
> + sreg->anatop = of_parse_phandle(np, "fsl,anatop", 0);
> + if (!sreg->anatop)
> + return -ENODEV;
In fact, that imx_syscon_lookup function I proposed could even do the
of_parse_phandle() internally, so perhaps:
foo->syscon_dev = imx_syscon_lookup(np, "fsl,anatop", 0);
if (IS_ERR(foo->syscon_dev))
return PTR_ERR(foo->syscon_dev);
with imx_syscon_lookup() internally knowing when to return EPROBE_DEFER
rather than any other permanent error code (e.g. for missing property,
bad phandle, etc.)
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Dong Aisheng <b29396@freescale.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com, s.hauer@pengutronix.de,
shawn.guo@linaro.org, kernel@pengutronix.de,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
sameo@linux.intel.com, lrg@ti.com,
broonie@opensource.wolfsonmicro.com, richard.zhao@freescale.com,
devicetree-discuss@lists.ozlabs.org, paul.liu@linaro.org
Subject: Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register
Date: Wed, 22 Aug 2012 23:21:03 -0600 [thread overview]
Message-ID: <5035BDBF.9020602@wwwdotorg.org> (raw)
In-Reply-To: <1345619928-15446-5-git-send-email-b29396@freescale.com>
On 08/22/2012 01:18 AM, Dong Aisheng wrote:
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c
> @@ -109,7 +110,11 @@ static int __devinit anatop_regulator_probe(struct platform_device *pdev)
> rdesc->ops = &anatop_rops;
> rdesc->type = REGULATOR_VOLTAGE;
> rdesc->owner = THIS_MODULE;
> - sreg->mfd = anatopmfd;
> +
> + sreg->anatop = of_parse_phandle(np, "fsl,anatop", 0);
> + if (!sreg->anatop)
> + return -ENODEV;
In fact, that imx_syscon_lookup function I proposed could even do the
of_parse_phandle() internally, so perhaps:
foo->syscon_dev = imx_syscon_lookup(np, "fsl,anatop", 0);
if (IS_ERR(foo->syscon_dev))
return PTR_ERR(foo->syscon_dev);
with imx_syscon_lookup() internally knowing when to return EPROBE_DEFER
rather than any other permanent error code (e.g. for missing property,
bad phandle, etc.)
next prev parent reply other threads:[~2012-08-23 5:21 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 7:18 [PATCH 0/7] add imx-syscon driver for general registers access Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` [PATCH 1/7] mfd: add imx syscon driver based on regmap Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 8:29 ` Richard Zhao
2012-08-22 8:29 ` Richard Zhao
2012-08-22 8:29 ` Richard Zhao
2012-08-22 10:57 ` Dong Aisheng
2012-08-22 10:57 ` Dong Aisheng
2012-08-23 5:16 ` Stephen Warren
2012-08-23 5:16 ` Stephen Warren
2012-08-23 6:09 ` Richard Zhao
2012-08-23 6:09 ` Richard Zhao
2012-08-23 6:09 ` Richard Zhao
2012-08-23 7:06 ` Dong Aisheng
2012-08-23 7:06 ` Dong Aisheng
2012-08-23 7:06 ` Dong Aisheng
2012-08-22 16:02 ` Mark Brown
2012-08-22 16:02 ` Mark Brown
2012-08-22 16:02 ` Mark Brown
2012-08-23 7:26 ` Dong Aisheng
2012-08-23 7:26 ` Dong Aisheng
2012-08-23 11:06 ` Mark Brown
2012-08-23 11:06 ` Mark Brown
2012-08-23 11:06 ` Mark Brown
2012-08-24 2:28 ` Dong Aisheng
2012-08-24 2:28 ` Dong Aisheng
2012-08-24 2:28 ` Dong Aisheng
2012-08-24 6:43 ` Shawn Guo
2012-08-24 6:43 ` Shawn Guo
2012-08-24 6:43 ` Shawn Guo
2012-08-22 7:18 ` [PATCH 2/7] ARM: imx6q: add iomuxc gpr support into imx-syscon Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` [PATCH 3/7] ARM: imx6q: add anatop " Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 15:59 ` Mark Brown
2012-08-22 15:59 ` Mark Brown
2012-08-23 7:15 ` Dong Aisheng
2012-08-23 7:15 ` Dong Aisheng
2012-08-23 7:15 ` Dong Aisheng
2012-08-23 11:17 ` Mark Brown
2012-08-23 11:17 ` Mark Brown
2012-08-24 2:29 ` Dong Aisheng
2012-08-24 2:29 ` Dong Aisheng
2012-08-23 5:21 ` Stephen Warren [this message]
2012-08-23 5:21 ` Stephen Warren
2012-08-23 6:12 ` Richard Zhao
2012-08-23 6:12 ` Richard Zhao
2012-08-23 6:12 ` Richard Zhao
2012-08-23 17:56 ` Stephen Warren
2012-08-23 17:56 ` Stephen Warren
2012-08-24 2:37 ` Dong Aisheng
2012-08-24 2:37 ` Dong Aisheng
2012-08-24 2:37 ` Dong Aisheng
2012-08-23 7:32 ` Dong Aisheng
2012-08-23 7:32 ` Dong Aisheng
2012-08-23 7:32 ` Dong Aisheng
2012-08-22 7:18 ` [PATCH 5/7] ARM: imx6q: convert to use imx-syscon to access anatop registers Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` [PATCH 6/7] ARM: dts: imx6q: add simple-bus compatible string for anatop Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 8:52 ` Richard Zhao
2012-08-22 8:52 ` Richard Zhao
2012-08-22 8:52 ` Richard Zhao
2012-08-22 11:02 ` Dong Aisheng
2012-08-22 11:02 ` Dong Aisheng
2012-08-22 7:18 ` [PATCH 7/7] mfd: anatop-mfd: remove anatop driver Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
2012-08-22 7:18 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5035BDBF.9020602@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.