All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Update MAX_EDID value in exynos
@ 2012-08-22 13:23 Shirish S
  2012-08-22 13:23 ` [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC Shirish S
  0 siblings, 1 reply; 6+ messages in thread
From: Shirish S @ 2012-08-22 13:23 UTC (permalink / raw)
  To: dri-devel, inki.dae; +Cc: aairlied, Shirish Shankarappa

From: Shirish Shankarappa <s.shirish@samsung.com>

The value of MAX_EDID is now valid only for 2
block EDID data which is 256, but to  support
4 block EDID (E-DDC) this needs to be 512.

Based on drm-next branch

Shirish Shankarappa (1):
  drm/exynos: Update the MAX_EDID value for E-DDC

 drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC
  2012-08-22 13:23 [PATCH] Update MAX_EDID value in exynos Shirish S
@ 2012-08-22 13:23 ` Shirish S
  2012-08-23  8:50   ` Daniel Vetter
  0 siblings, 1 reply; 6+ messages in thread
From: Shirish S @ 2012-08-22 13:23 UTC (permalink / raw)
  To: dri-devel, inki.dae; +Cc: aairlied, Shirish Shankarappa

From: Shirish Shankarappa <s.shirish@samsung.com>

The value of MAX_EDID is now valid only for 2
block EDID data which is 256, but to  support
4 block EDID (E-DDC) this needs to be 512.

Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
index d956819..69d02b5 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
@@ -32,7 +32,7 @@
 #include "exynos_drm_drv.h"
 #include "exynos_drm_encoder.h"
 
-#define MAX_EDID 256
+#define MAX_EDID 512
 #define to_exynos_connector(x)	container_of(x, struct exynos_drm_connector,\
 				drm_connector)
 
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC
  2012-08-23  7:03 [PATCH] Update MAX_EDID value in exynos Shirish S
@ 2012-08-23  7:03 ` Shirish S
  0 siblings, 0 replies; 6+ messages in thread
From: Shirish S @ 2012-08-23  7:03 UTC (permalink / raw)
  To: inki.dae, dri-devel

The value of MAX_EDID is now valid only for 2
block EDID data which is 256, but to  support
4 block EDID (E-DDC) this needs to be 512.

Signed-off-by: Shirish S <s.shirish@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
index d956819..69d02b5 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
@@ -32,7 +32,7 @@
 #include "exynos_drm_drv.h"
 #include "exynos_drm_encoder.h"
 
-#define MAX_EDID 256
+#define MAX_EDID 512
 #define to_exynos_connector(x)	container_of(x, struct exynos_drm_connector,\
 				drm_connector)
 
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC
  2012-08-22 13:23 ` [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC Shirish S
@ 2012-08-23  8:50   ` Daniel Vetter
  2012-08-23  9:52     ` 김승우
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2012-08-23  8:50 UTC (permalink / raw)
  To: Shirish S; +Cc: aairlied, dri-devel

On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote:
> From: Shirish Shankarappa <s.shirish@samsung.com>
> 
> The value of MAX_EDID is now valid only for 2
> block EDID data which is 256, but to  support
> 4 block EDID (E-DDC) this needs to be 512.
> 
> Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
> index d956819..69d02b5 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
> @@ -32,7 +32,7 @@
>  #include "exynos_drm_drv.h"
>  #include "exynos_drm_encoder.h"
>  
> -#define MAX_EDID 256
> +#define MAX_EDID 512
>  #define to_exynos_connector(x)	container_of(x, struct exynos_drm_connector,\
>  				drm_connector)

Shouldn't this be in a common drm/edid header to begin with?
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC
  2012-08-23  8:50   ` Daniel Vetter
@ 2012-08-23  9:52     ` 김승우
  2012-08-23 14:01       ` Shirish S
  0 siblings, 1 reply; 6+ messages in thread
From: 김승우 @ 2012-08-23  9:52 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: kyungmin.park, aairlied, Shirish S, dri-devel

Hi Daniel,

On 2012년 08월 23일 17:50, Daniel Vetter wrote:
> On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote:
>> From: Shirish Shankarappa <s.shirish@samsung.com>
>>
>> The value of MAX_EDID is now valid only for 2
>> block EDID data which is 256, but to  support
>> 4 block EDID (E-DDC) this needs to be 512.
>>
>> Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> index d956819..69d02b5 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> @@ -32,7 +32,7 @@
>>  #include "exynos_drm_drv.h"
>>  #include "exynos_drm_encoder.h"
>>  
>> -#define MAX_EDID 256
>> +#define MAX_EDID 512
>>  #define to_exynos_connector(x)	container_of(x, struct exynos_drm_connector,\
>>  				drm_connector)
> 
> Shouldn't this be in a common drm/edid header to begin with?

This value is not real maximum length of EDID and it is only used for
memory allocation by exynos connector. Actually, this allocation is
unnecessary because edid is already allocated by drm_get_edid().

So, I have plan to remove this allocation and the definition once Jani
Nikula's patches for removing raw_edid related memory leaks are applied.

> -Daniel
> 

Thanks and Regards,
- Seung-Woo Kim


-- 
Seung-Woo Kim
Samsung Software R&D Center
--

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC
  2012-08-23  9:52     ` 김승우
@ 2012-08-23 14:01       ` Shirish S
  0 siblings, 0 replies; 6+ messages in thread
From: Shirish S @ 2012-08-23 14:01 UTC (permalink / raw)
  To: sw0312.kim; +Cc: dri-devel, kyungmin.park, aairlied, Shirish S


[-- Attachment #1.1: Type: text/plain, Size: 2166 bytes --]

Hello,

On Thu, Aug 23, 2012 at 2:52 AM, 김승우 <sw0312.kim@samsung.com> wrote:

> Hi Daniel,
>
> On 2012년 08월 23일 17:50, Daniel Vetter wrote:
> > On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote:
> >> From: Shirish Shankarappa <s.shirish@samsung.com>
> >>
> >> The value of MAX_EDID is now valid only for 2
> >> block EDID data which is 256, but to  support
> >> 4 block EDID (E-DDC) this needs to be 512.
> >>
> >> Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com>
> >> ---
> >>  drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c
> b/drivers/gpu/drm/exynos/exynos_drm_connector.c
> >> index d956819..69d02b5 100644
> >> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
> >> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
> >> @@ -32,7 +32,7 @@
> >>  #include "exynos_drm_drv.h"
> >>  #include "exynos_drm_encoder.h"
> >>
> >> -#define MAX_EDID 256
> >> +#define MAX_EDID 512
> >>  #define to_exynos_connector(x)      container_of(x, struct
> exynos_drm_connector,\
> >>                              drm_connector)
> >
> > Shouldn't this be in a common drm/edid header to begin with?
>
> This value is not real maximum length of EDID and it is only used for
> memory allocation by exynos connector. Actually, this allocation is
> unnecessary because edid is already allocated by drm_get_edid().
>
> So, I have plan to remove this allocation and the definition once Jani
> Nikula's patches for removing raw_edid related memory leaks are applied.
>
> I was not aware of your plans to remove it, anyways for verifying the
patch for 4 block EDID data,
this modification is required,hence i thought of posting this patch.


> > -Daniel
> >
>
> Thanks and Regards,
> - Seung-Woo Kim
>
>
> --
> Seung-Woo Kim
> Samsung Software R&D Center
> --
>
> Thanks& Regards,
Shirish S

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>

[-- Attachment #1.2: Type: text/html, Size: 3531 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-23 14:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 13:23 [PATCH] Update MAX_EDID value in exynos Shirish S
2012-08-22 13:23 ` [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC Shirish S
2012-08-23  8:50   ` Daniel Vetter
2012-08-23  9:52     ` 김승우
2012-08-23 14:01       ` Shirish S
  -- strict thread matches above, loose matches on Subject: below --
2012-08-23  7:03 [PATCH] Update MAX_EDID value in exynos Shirish S
2012-08-23  7:03 ` [PATCH] drm/exynos: Update the MAX_EDID value for E-DDC Shirish S

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.