From: Clemens Ladisch <clemens@ladisch.de>
To: Dylan Reid <dgreid@chromium.org>
Cc: alsa-devel@alsa-project.org, kgene.kim@samsung.com,
alim.akhtar@samsung.com, jassi.brar@samsung.com,
padma.v@samsung.com, broonie@opensource.wolfsonmicro.com,
ben-linux@fluff.org, olofj@chromium.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: samsung dma - prepare dma in start/resume trigger path
Date: Fri, 24 Aug 2012 09:15:00 +0200 [thread overview]
Message-ID: <503729F4.5090805@ladisch.de> (raw)
In-Reply-To: <1345755069-9512-1-git-send-email-dgreid@chromium.org>
Dylan Reid wrote:
> On suspend all dma transactions are terminated (by the stop/suspend
> trigger calling ops->stop), they need to be set up again during resume.
> Move the prepare op to the start/resume/unpause trigger path so that dma
> and audio will restart on resume/unpause.
TRIGGER_RESUME must restart the stream at the buffer position at which
it was suspended. If the driver is not capable of that, it must not
support TRIGGER_SUSPEND/RESUME in the first place (i.e., remove
SNDRV_PCM_INFO_RESUME).
Regards,
Clemens
WARNING: multiple messages have this Message-ID (diff)
From: clemens@ladisch.de (Clemens Ladisch)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: samsung dma - prepare dma in start/resume trigger path
Date: Fri, 24 Aug 2012 09:15:00 +0200 [thread overview]
Message-ID: <503729F4.5090805@ladisch.de> (raw)
In-Reply-To: <1345755069-9512-1-git-send-email-dgreid@chromium.org>
Dylan Reid wrote:
> On suspend all dma transactions are terminated (by the stop/suspend
> trigger calling ops->stop), they need to be set up again during resume.
> Move the prepare op to the start/resume/unpause trigger path so that dma
> and audio will restart on resume/unpause.
TRIGGER_RESUME must restart the stream at the buffer position at which
it was suspended. If the driver is not capable of that, it must not
support TRIGGER_SUSPEND/RESUME in the first place (i.e., remove
SNDRV_PCM_INFO_RESUME).
Regards,
Clemens
next prev parent reply other threads:[~2012-08-24 7:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 20:51 [PATCH] ASoC: samsung dma - prepare dma in start/resume trigger path Dylan Reid
2012-08-23 20:51 ` Dylan Reid
2012-08-23 20:54 ` Dylan Reid
2012-08-23 20:54 ` Dylan Reid
2012-08-24 7:15 ` Clemens Ladisch [this message]
2012-08-24 7:15 ` [alsa-devel] " Clemens Ladisch
2012-08-24 7:41 ` Sangbeom Kim
2012-08-24 7:41 ` [alsa-devel] " Sangbeom Kim
2012-08-24 7:52 ` Dylan Reid
2012-08-24 7:52 ` [alsa-devel] " Dylan Reid
2012-08-24 10:06 ` Sangbeom Kim
2012-08-24 10:06 ` [alsa-devel] " Sangbeom Kim
2012-08-24 17:29 ` Dylan Reid
2012-08-24 17:29 ` [alsa-devel] " Dylan Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503729F4.5090805@ladisch.de \
--to=clemens@ladisch.de \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dgreid@chromium.org \
--cc=jassi.brar@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=olofj@chromium.org \
--cc=padma.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.