From: Hannes Reinecke <hare@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast
Date: Fri, 24 Aug 2012 12:37:11 +0200 [thread overview]
Message-ID: <50375957.7040803@suse.de> (raw)
In-Reply-To: <50373871.9020809@redhat.com>
On 08/24/2012 10:16 AM, Paolo Bonzini wrote:
> Il 24/08/2012 10:31, Hannes Reinecke ha scritto:
>>
>>> Type casts from pointer to integer values must use uintptr_t
>>> instead of unsigned long. Otherwise the compiler complains on
>>> hosts with sizeof(pointer) != sizeof(long).
>>>
>>> The patch also replace magic number 32 by sizeof(info.serial_number)
>>> which has the same value but is better for code reviews.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>
>> Sigh. I never seem to get the hang of typecasting.
>>
>> Acked-by: Hannes Reinecke <hare@suse.de>
>
> Nope, this needs to be fixed using the same scheme that you used for SAS
> addresses. Quick before Anthony notices and disables MEGASAS. :)
>
Ok, done.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
prev parent reply other threads:[~2012-08-24 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 21:02 [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast Stefan Weil
2012-08-24 8:31 ` Hannes Reinecke
2012-08-24 8:16 ` Paolo Bonzini
2012-08-24 10:37 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50375957.7040803@suse.de \
--to=hare@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.