[Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)

[Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)

[Joerg Mayer]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

Note: Is this this flag supported on all compilers?

Signed-off-by: Joerg Mayer <jmpt(a)loplof.de>

diff --git a/src/Makefile.am b/src/Makefile.am
index d233d85..ec70bc4 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -33,8 +33,9 @@ powertop_SOURCES = parameters/persistent.cpp parameters/learn.cpp parameters/par
 		main.cpp css.h powertop.css cpu/intel_gpu.cpp
 
 
-powertop_CXXFLAGS = -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
-
+powertop_CXXFLAGS = \
+	-fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -Wno-unused-result \
+	$(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
 
 powertop_CPPFLAGS = -D_FORTIFY_SOURCE=2 $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS) $(LIBZ_CFLAGS) -DLOCALEDIR=\"$(localedir)\"
 
-- 
1.7.7

Re: [Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)

[Magnus Fromreide]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

On Fri, 2012-08-24 at 18:53 +0200, Joerg Mayer wrote:
> Note: Is this this flag supported on all compilers?

Please don't.

If you really mean to ignore the result values then the canonical thing
to do is to cast them to (void)

/MF

Re: [Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)

[Chris Ferron]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

On 08/24/2012 10:38 AM, Magnus Fromreide wrote:
> On Fri, 2012-08-24 at 18:53 +0200, Joerg Mayer wrote:
>> Note: Is this this flag supported on all compilers?
> Please don't.
>
> If you really mean to ignore the result values then the canonical thing
> to do is to cast them to (void)
Agreed. Also really don't want this as some of the results that are 
being ignored should really be fixed. Meaning wrapped in error handling.
>
> /MF
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop

Re: [Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)

[Joerg Mayer]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

On Fri, Aug 24, 2012 at 10:54:17AM -0700, Chris Ferron wrote:
> On 08/24/2012 10:38 AM, Magnus Fromreide wrote:
> >On Fri, 2012-08-24 at 18:53 +0200, Joerg Mayer wrote:
> >>Note: Is this this flag supported on all compilers?
> >Please don't.
> >
> >If you really mean to ignore the result values then the canonical thing
> >to do is to cast them to (void)
> Agreed. Also really don't want this as some of the results that are
> being ignored should really be fixed. Meaning wrapped in error
> handling.

OK, I expected this part of the patch series to be controversial - so just
skip it.

Thanks
    Jörg
-- 
Joerg Mayer                                           <jmayer(a)loplof.de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.