From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] vmscan: sleep only if backingdev is congested
Date: Sat, 25 Aug 2012 19:02:49 -0400 [thread overview]
Message-ID: <50395999.1030004@redhat.com> (raw)
In-Reply-To: <1345619717-5322-3-git-send-email-minchan@kernel.org>
On 08/22/2012 03:15 AM, Minchan Kim wrote:
> +++ b/mm/vmscan.c
> @@ -2705,8 +2705,16 @@ loop_again:
> if (total_scanned && (sc.priority < DEF_PRIORITY - 2)) {
> if (has_under_min_watermark_zone)
> count_vm_event(KSWAPD_SKIP_CONGESTION_WAIT);
> - else
> - congestion_wait(BLK_RW_ASYNC, HZ/10);
> + else {
> + for (i = 0; i <= end_zone; i++) {
> + struct zone *zone = pgdat->node_zones
> + + i;
> + if (!populated_zone(zone))
> + continue;
> + wait_iff_congested(zone, BLK_RW_ASYNC,
> + HZ/10);
> + }
> + }
> }
Do we really want to wait on every zone?
That could increase the sleep time by a factor 3.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] vmscan: sleep only if backingdev is congested
Date: Sat, 25 Aug 2012 19:02:49 -0400 [thread overview]
Message-ID: <50395999.1030004@redhat.com> (raw)
In-Reply-To: <1345619717-5322-3-git-send-email-minchan@kernel.org>
On 08/22/2012 03:15 AM, Minchan Kim wrote:
> +++ b/mm/vmscan.c
> @@ -2705,8 +2705,16 @@ loop_again:
> if (total_scanned && (sc.priority < DEF_PRIORITY - 2)) {
> if (has_under_min_watermark_zone)
> count_vm_event(KSWAPD_SKIP_CONGESTION_WAIT);
> - else
> - congestion_wait(BLK_RW_ASYNC, HZ/10);
> + else {
> + for (i = 0; i <= end_zone; i++) {
> + struct zone *zone = pgdat->node_zones
> + + i;
> + if (!populated_zone(zone))
> + continue;
> + wait_iff_congested(zone, BLK_RW_ASYNC,
> + HZ/10);
> + }
> + }
> }
Do we really want to wait on every zone?
That could increase the sleep time by a factor 3.
--
All rights reversed
next prev parent reply other threads:[~2012-08-25 23:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 7:15 [RFC 0/5] Consider higher small zone and mmaped-pages stream Minchan Kim
2012-08-22 7:15 ` Minchan Kim
2012-08-22 7:15 ` [PATCH 1/5] vmscan: Fix obsolete comment of balance_pgdat Minchan Kim
2012-08-22 7:15 ` Minchan Kim
2012-08-23 17:37 ` Rik van Riel
2012-08-23 17:37 ` Rik van Riel
2012-08-22 7:15 ` [PATCH 2/5] vmscan: sleep only if backingdev is congested Minchan Kim
2012-08-22 7:15 ` Minchan Kim
2012-08-25 23:02 ` Rik van Riel [this message]
2012-08-25 23:02 ` Rik van Riel
2012-08-22 7:15 ` [PATCH 3/5] vmscan: prevent excessive pageout of kswapd Minchan Kim
2012-08-22 7:15 ` Minchan Kim
2012-08-22 7:15 ` [PATCH 4/5] vmscan: get rid of unnecessary nr_dirty ret variable Minchan Kim
2012-08-22 7:15 ` Minchan Kim
2012-08-22 7:15 ` [PATCH 5/5] vmscan: accelerate to reclaim mapped-pages stream Minchan Kim
2012-08-22 7:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50395999.1030004@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.