[patch] "Junior" ToDo Warn if Modesetting Disabled

[patch] "Junior" ToDo Warn if Modesetting Disabled

[mwc28-CklgBQt3EwWO6V2BHUzxHg]

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

Hi,

ToDo list item - totally untested.

Bikeshed away about the text of the message and I can change.

Cheers,

Mark

[-- Attachment #2: modeset.patch --]
[-- Type: text/x-patch, Size: 1061 bytes --]

From cc3257d8b29c5302de869bfb2a442a1daf01f387 Mon Sep 17 00:00:00 2001
From: Mark Carey <mark-CklgBQt3EwWO6V2BHUzxHg@public.gmane.org>
Date: Sun, 26 Aug 2012 21:09:39 +1200
Subject: [PATCH] drm/nouveau: warn during init if modesetting disabled

Reported-by: Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org>
Signed-off-by: Mark Carey <mark-CklgBQt3EwWO6V2BHUzxHg@public.gmane.org>
---
 drivers/gpu/drm/nouveau/nouveau_drm.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 9fb56b3..3dbf081 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -655,8 +655,11 @@ nouveau_drm_init(void)
 			nouveau_modeset = 1;
 	}
 
-	if (!nouveau_modeset)
+    if (!nouveau_modeset) {
+		NV_FATAL(NULL, "modesetting disabled\n");
+		NV_FATAL(NULL, "modesetting required for normal operation\n");
 		return 0;
+    }
 
 	nouveau_register_dsm_handler();
 	return drm_pci_init(&driver, &nouveau_drm_pci_driver);
-- 
1.7.5.1


[-- Attachment #3: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [patch] "Junior" ToDo Warn if Modesetting Disabled

[Mark Carey]

[-- Attachment #1: Type: text/plain, Size: 53 bytes --]

v2 spaces to tabs as per RSpliets feedback on IRC




[-- Attachment #2: modeset.patch --]
[-- Type: text/x-patch, Size: 1055 bytes --]

From 55370ae2ef1df30a7d15b454fc6189f74675e011 Mon Sep 17 00:00:00 2001
From: Mark Carey <mark-CklgBQt3EwWO6V2BHUzxHg@public.gmane.org>
Date: Sun, 26 Aug 2012 22:09:17 +1200
Subject: [PATCH] drm/nouveau: warn during init if modesetting disabled

Reported-by: Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org>
Signed-off-by: Mark Carey <mark-CklgBQt3EwWO6V2BHUzxHg@public.gmane.org>
---
 drivers/gpu/drm/nouveau/nouveau_drm.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 9fb56b3..aa9d3f6 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -655,8 +655,11 @@ nouveau_drm_init(void)
 			nouveau_modeset = 1;
 	}
 
-	if (!nouveau_modeset)
+	if (!nouveau_modeset) {
+		NV_FATAL(NULL, "modesetting disabled\n");
+		NV_FATAL(NULL, "modesetting required for normal operation\n");
 		return 0;
+	}
 
 	nouveau_register_dsm_handler();
 	return drm_pci_init(&driver, &nouveau_drm_pci_driver);
-- 
1.7.5.1


[-- Attachment #3: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [patch] "Junior" ToDo Warn if Modesetting Disabled

[Martin Peres]

On 26/08/2012 23:05, Mark Carey wrote:
> v2 spaces to tabs as per RSpliets feedback on IRC
Hi Mark,

Thanks for the patch, it is indeed needed :)

However, I don't like the wording. Instead of telling that it isn't 
normal, we don't tell what should be done neither what it will impact.
I guess something like "modesetting disabled, hw acceleration disabled" 
would be more suitable.

Speaking about that, I wonder how Nouveau would work on a CRTC-less card :D

Martin

PS: I have tested booting Arch with "nomodeset" and x-server loads VESA. 
Exactly the behaviour we are looking for :)