* [PATCH] extcon: arizona: Free MICDET IRQ on error during probe
@ 2012-08-26 20:58 Mark Brown
2012-08-26 23:54 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-08-26 20:58 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi, Greg Kroah-Hartman
Cc: linux-kernel, patches, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/extcon/extcon-arizona.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index fa2114f..13eafcb 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
ret = input_register_device(info->input);
if (ret) {
dev_err(&pdev->dev, "Can't register input device: %d\n", ret);
- goto err_fall_wake;
+ goto err_micdet;
}
return 0;
+err_micdet:
+ arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
err_fall_wake:
arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
err_fall:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe
2012-08-26 20:58 [PATCH] extcon: arizona: Free MICDET IRQ on error during probe Mark Brown
@ 2012-08-26 23:54 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2012-08-26 23:54 UTC (permalink / raw)
To: Mark Brown; +Cc: MyungJoo Ham, Greg Kroah-Hartman, linux-kernel, patches
On 08/27/2012 05:58 AM, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index fa2114f..13eafcb 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
> ret = input_register_device(info->input);
> if (ret) {
> dev_err(&pdev->dev, "Can't register input device: %d\n", ret);
> - goto err_fall_wake;
> + goto err_micdet;
> }
>
> return 0;
>
> +err_micdet:
> + arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
> err_fall_wake:
> arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
> err_fall:
Thanks much,
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-26 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-26 20:58 [PATCH] extcon: arizona: Free MICDET IRQ on error during probe Mark Brown
2012-08-26 23:54 ` Chanwoo Choi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.