From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: "Laxman Dewangan"
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
djbw-b10kYP2dOMg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dma: tegra: add const to of_device_id.data's structure
Date: Sun, 26 Aug 2012 21:25:26 -0700 [thread overview]
Message-ID: <503AF6B6.1010808@nvidia.com> (raw)
In-Reply-To: <1345976063-24437-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 08/26/2012 03:14 AM, Laxman Dewangan wrote:
> The membe "data" of structure of_device_id is changed to const
> pointer. Hence initializing this with const type data.
> This will fix the compilation warning like
> drivers/dma/tegra20-apb-dma.c:1217:9: warning: assignment discards 'const' qualifier from
> pointer target type [enabled by default]
>
> This warning came after the change
> ---------
> commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
> Author: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> of: add const to struct *of_device_id.data
> ---------
Acked-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
I wonder if this should go through Uwe's branch that made similar
changes for all other drivers though? Uwe now CC'd.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@nvidia.com>
To: "Laxman Dewangan" <ldewangan@nvidia.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: vinod.koul@intel.com, djbw@fb.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] dma: tegra: add const to of_device_id.data's structure
Date: Sun, 26 Aug 2012 21:25:26 -0700 [thread overview]
Message-ID: <503AF6B6.1010808@nvidia.com> (raw)
In-Reply-To: <1345976063-24437-1-git-send-email-ldewangan@nvidia.com>
On 08/26/2012 03:14 AM, Laxman Dewangan wrote:
> The membe "data" of structure of_device_id is changed to const
> pointer. Hence initializing this with const type data.
> This will fix the compilation warning like
> drivers/dma/tegra20-apb-dma.c:1217:9: warning: assignment discards 'const' qualifier from
> pointer target type [enabled by default]
>
> This warning came after the change
> ---------
> commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> of: add const to struct *of_device_id.data
> ---------
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
I wonder if this should go through Uwe's branch that made similar
changes for all other drivers though? Uwe now CC'd.
next prev parent reply other threads:[~2012-08-27 4:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 10:14 [PATCH] dma: tegra: add const to of_device_id.data's structure Laxman Dewangan
2012-08-26 10:14 ` Laxman Dewangan
[not found] ` <1345976063-24437-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-27 4:25 ` Stephen Warren [this message]
2012-08-27 4:25 ` Stephen Warren
[not found] ` <503AF6B6.1010808-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-28 18:38 ` Uwe Kleine-König
2012-08-28 18:38 ` Uwe Kleine-König
2012-08-28 22:08 ` Vinod Koul
2012-08-28 22:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503AF6B6.1010808@nvidia.com \
--to=swarren-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=djbw-b10kYP2dOMg@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.