Re: -next queue and EDID stuff

[Ian Pilcher <arequipeno@gmail.com>]

On 08/28/2012 07:13 PM, Adam Jackson wrote:
> On 8/28/12 7:33 PM, Ian Pilcher wrote:
>> Actually, I believe that the error is probably in the Intel driver.  As
>> I understand it, it shouldn't be sending audio InfoFrames to a non-HDMI
>> display.
> 
> If that's the case then I'd still say "we're doing something else wrong
> here".  Quirks - at least at the core drm level - are not for working
> around broken drivers, they're for working around broken displays.

And I'd agree.

(Although I suppose one *could* argue that the display is broken in 2
ways -- it reports audio capabilities that aren't really there, and it
gets confused by any InfoFrames -- AVI or audio.)

I don't have the knowledge or time to fix the Intel driver, but I've
always planned to at least bugzilla the issue.  I can't reasonably do
so, however, until the user-defined quirks infrastructure is in place,
so that the behavior can be demonstrated.

If you prefer to leave the display broken with Intel GPUs, you can
always just remove the EDID_QUIRK_NO_AUDIO flag:

--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -160,6 +160,10 @@  union edid_quirk
edid_quirk_list[EDID_QUIRK_LIST_SIZE] = {
 	{ { { { EDID_MFG_ID('V', 'S', 'C'), cpu_to_le16(5020) } },
 		EDID_QUIRK_FORCE_REDUCED_BLANKING } },

+	/* LG L246WP */
+	{ { { { EDID_MFG_ID('G', 'S', 'M'), cpu_to_le16(0x563f) } },
+		EDID_QUIRK_DISABLE_INFOFRAMES } },
+
 	/*
 	 * When adding built-in quirks, please adjust EDID_QUIRK_LIST_SIZE to
 	 * provide some room for user-supplied quirks.

-- 
========================================================================
Ian Pilcher                                         arequipeno@gmail.com
"If you're going to shift my paradigm ... at least buy me dinner first."
========================================================================