* [PATCH] crypto: 842 - remove .cra_list initialization
@ 2012-08-29 20:37 Jussi Kivilinna
2012-08-29 22:12 ` Seth Jennings
2012-09-06 20:22 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Jussi Kivilinna @ 2012-08-29 20:37 UTC (permalink / raw)
To: linux-crypto; +Cc: Seth Jennings, Robert Jennings, Herbert Xu, David S. Miller
.cra_list initialization is unneeded and have been removed from all other
crypto modules except 842.
Cc: Robert Jennings <rcj@linux.vnet.ibm.com>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
---
I don't have ppc64 cross-compiler set up, so I couldn't test this. However
patch is obvious and should work.
---
crypto/842.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/crypto/842.c b/crypto/842.c
index 144767d..65c7a89c 100644
--- a/crypto/842.c
+++ b/crypto/842.c
@@ -157,7 +157,6 @@ static struct crypto_alg alg = {
.cra_flags = CRYPTO_ALG_TYPE_COMPRESS,
.cra_ctxsize = sizeof(struct nx842_ctx),
.cra_module = THIS_MODULE,
- .cra_list = LIST_HEAD_INIT(alg.cra_list),
.cra_init = nx842_init,
.cra_exit = nx842_exit,
.cra_u = { .compress = {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: 842 - remove .cra_list initialization
2012-08-29 20:37 [PATCH] crypto: 842 - remove .cra_list initialization Jussi Kivilinna
@ 2012-08-29 22:12 ` Seth Jennings
2012-09-06 20:22 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Seth Jennings @ 2012-08-29 22:12 UTC (permalink / raw)
To: Jussi Kivilinna
Cc: linux-crypto, Robert Jennings, Herbert Xu, David S. Miller
On 08/29/2012 03:37 PM, Jussi Kivilinna wrote:
> .cra_list initialization is unneeded and have been removed from all other
> crypto modules except 842.
>
> Cc: Robert Jennings <rcj@linux.vnet.ibm.com>
> Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
>
> ---
>
> I don't have ppc64 cross-compiler set up, so I couldn't test this. However
> patch is obvious and should work.
Applied on top of next-20120824 and it builds on ppc64, just
for peace of mind :)
I see the other patch in next that did this for all the others.
Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
--
Seth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: 842 - remove .cra_list initialization
2012-08-29 20:37 [PATCH] crypto: 842 - remove .cra_list initialization Jussi Kivilinna
2012-08-29 22:12 ` Seth Jennings
@ 2012-09-06 20:22 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2012-09-06 20:22 UTC (permalink / raw)
To: Jussi Kivilinna
Cc: linux-crypto, Seth Jennings, Robert Jennings, David S. Miller
On Wed, Aug 29, 2012 at 11:37:25PM +0300, Jussi Kivilinna wrote:
> .cra_list initialization is unneeded and have been removed from all other
> crypto modules except 842.
>
> Cc: Robert Jennings <rcj@linux.vnet.ibm.com>
> Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-06 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-29 20:37 [PATCH] crypto: 842 - remove .cra_list initialization Jussi Kivilinna
2012-08-29 22:12 ` Seth Jennings
2012-09-06 20:22 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.