From: Adam Jackson <ajax@redhat.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ian Pilcher <arequipeno@gmail.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/hdmi: only enable audio if there's a hdmi sink
Date: Thu, 30 Aug 2012 11:32:34 -0400 [thread overview]
Message-ID: <503F8792.5050006@redhat.com> (raw)
In-Reply-To: <1346312676-17857-1-git-send-email-daniel.vetter@ffwll.ch>
On 8/30/12 3:44 AM, Daniel Vetter wrote:
> Some monitors totally don't like to receive infoframes, and naturally
> don't claim to support hdmi.
>
> But for some odd reason they've added a CEA block to their edid,
> which automatically gives you basic audio. Still, we may not send
> out hdmi infoframes to them, hence check whether the sink is indeed
> hdmi capable.
>
> Also kill a stale comment while at it.
Does an incomplete version of what it says on the box, you need to hit
the HDMI code in intel_sdvo.c too.
At which point, should do the obvious bool drm_monitor_has_hdmi_audio()
in drm_edid.c.
- ajax
prev parent reply other threads:[~2012-08-30 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 7:44 [PATCH] drm/i915/hdmi: only enable audio if there's a hdmi sink Daniel Vetter
2012-08-30 15:32 ` Adam Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503F8792.5050006@redhat.com \
--to=ajax@redhat.com \
--cc=arequipeno@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.