From: Sasha Levin <levinsasha928@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: avi@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible
Date: Fri, 31 Aug 2012 11:36:07 +0200 [thread overview]
Message-ID: <50408587.5030603@gmail.com> (raw)
In-Reply-To: <20120830133820.GC21132@redhat.com>
On 08/30/2012 03:38 PM, Michael S. Tsirkin wrote:
>> +static unsigned int indirect_alloc_thresh = 16;
> Why 16? Please make is MAX_SG + 1 this makes some sense.
Wouldn't MAX_SG mean we always allocate from the cache? Isn't the memory waste
too big in this case?
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <levinsasha928@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, avi@redhat.com,
kvm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible
Date: Fri, 31 Aug 2012 11:36:07 +0200 [thread overview]
Message-ID: <50408587.5030603@gmail.com> (raw)
In-Reply-To: <20120830133820.GC21132@redhat.com>
On 08/30/2012 03:38 PM, Michael S. Tsirkin wrote:
>> +static unsigned int indirect_alloc_thresh = 16;
> Why 16? Please make is MAX_SG + 1 this makes some sense.
Wouldn't MAX_SG mean we always allocate from the cache? Isn't the memory waste
too big in this case?
next prev parent reply other threads:[~2012-08-31 9:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 11:21 [PATCH v3 1/2] virtio-ring: Use threshold for switching to indirect descriptors Sasha Levin
2012-08-30 11:21 ` Sasha Levin
2012-08-30 11:21 ` [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible Sasha Levin
2012-08-30 11:21 ` Sasha Levin
2012-08-30 13:38 ` Michael S. Tsirkin
2012-08-30 13:38 ` Michael S. Tsirkin
2012-08-31 9:36 ` Sasha Levin [this message]
2012-08-31 9:36 ` Sasha Levin
2012-08-31 9:56 ` Michael S. Tsirkin
2012-08-31 9:56 ` Michael S. Tsirkin
2012-09-04 16:34 ` Avi Kivity
2012-09-04 16:34 ` Avi Kivity
2012-09-04 16:36 ` Avi Kivity
2012-09-04 16:36 ` Avi Kivity
2012-09-04 18:41 ` Michael S. Tsirkin
2012-09-04 18:41 ` Michael S. Tsirkin
2012-09-05 14:21 ` Avi Kivity
2012-09-05 14:21 ` Avi Kivity
2012-09-05 14:27 ` Michael S. Tsirkin
2012-09-05 14:27 ` Michael S. Tsirkin
2012-08-30 14:14 ` [PATCH v3 1/2] virtio-ring: Use threshold for switching to indirect descriptors Michael S. Tsirkin
2012-08-30 14:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50408587.5030603@gmail.com \
--to=levinsasha928@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.