From: Don Slutz <Don@CloudSwitch.Com>
To: Fred Oliveira <foliveira@cloudswitch.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G
Date: Fri, 31 Aug 2012 10:04:13 -0400 [thread overview]
Message-ID: <5040C45D.8000106@CloudSwitch.Com> (raw)
In-Reply-To: <1346416208-28004-1-git-send-email-foliveira@cloudswitch.com>
On 08/31/12 08:30, Fred Oliveira wrote:
> The check using INT_MAX (2147483647) is wrong in this case.
>
> Signed-off-by: Fred Oliveira <foliveira@cloudswitch.com>
> ---
> target-i386/cpu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 423e009..cbc172e 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -846,7 +846,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
> {
> X86CPU *cpu = X86_CPU(obj);
> const int64_t min = 0;
> - const int64_t max = INT_MAX;
> + const int64_t max = INT64_MAX;
> int64_t value;
>
> visit_type_int(v, &value, name, errp);
I think this a *trivial patch. Adding *qemu-trivial@nongnu.org.
-Don Slutz
**
WARNING: multiple messages have this Message-ID (diff)
From: Don Slutz <Don@CloudSwitch.Com>
To: Fred Oliveira <foliveira@cloudswitch.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G
Date: Fri, 31 Aug 2012 10:04:13 -0400 [thread overview]
Message-ID: <5040C45D.8000106@CloudSwitch.Com> (raw)
In-Reply-To: <1346416208-28004-1-git-send-email-foliveira@cloudswitch.com>
On 08/31/12 08:30, Fred Oliveira wrote:
> The check using INT_MAX (2147483647) is wrong in this case.
>
> Signed-off-by: Fred Oliveira <foliveira@cloudswitch.com>
> ---
> target-i386/cpu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 423e009..cbc172e 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -846,7 +846,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
> {
> X86CPU *cpu = X86_CPU(obj);
> const int64_t min = 0;
> - const int64_t max = INT_MAX;
> + const int64_t max = INT64_MAX;
> int64_t value;
>
> visit_type_int(v, &value, name, errp);
I think this a *trivial patch. Adding *qemu-trivial@nongnu.org.
-Don Slutz
**
next prev parent reply other threads:[~2012-08-31 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 12:30 [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G Fred Oliveira
2012-08-31 14:04 ` Don Slutz [this message]
2012-08-31 14:04 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040C45D.8000106@CloudSwitch.Com \
--to=don@cloudswitch.com \
--cc=foliveira@cloudswitch.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.