All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Hiremath <hvaibhav@ti.com>
To: Russell King <linux@arm.linux.org.uk>,
	Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>,
	Benoit Cousson <b-cousson@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Without MACH_ option Early printk (DEBUG_LL)
Date: Fri, 31 Aug 2012 20:24:51 +0530	[thread overview]
Message-ID: <5040D03B.2050304@ti.com> (raw)

Hi Russell & Tony,

AM335X EVM (based on AM33XX device) only supports DT boot mode and
doesn't have CONFIG_MACH_AM335XEVM option defined. Some time back during
baseport submission we had aligned that, we won't create separate EVM
options, killing the board file all-together.

Having said that, the early printk option (DEBUG_LL) is broken, the
auto-generated file "./include/generated/mach-types.h" still refers to
CONFIG_MACH_AM335XEVM option,

#ifdef CONFIG_MACH_AM335XEVM
# ifdef machine_arch_type
#  undef machine_arch_type
#  define machine_arch_type     __machine_arch_type
# else
#  define machine_arch_type     MACH_TYPE_AM335XEVM
# endif
# define machine_is_am335xevm() (machine_arch_type == MACH_TYPE_AM335XEVM)
#else
# define machine_is_am335xevm() (0)
#endif


So I am thinking of changing the config_xxx option to SOC_AM33XX or
ARCH_OMAP2PLUS, something like below,

am335xevm        SOC_AM33XX          AM335XEVM         3589

OR

am335xevm        ARCH_OMAP2PLUS      AM335XEVM         3589


Can you comment on this? Based on that I will submit the patch.

Thanks,
Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: hvaibhav@ti.com (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: Without MACH_ option Early printk (DEBUG_LL)
Date: Fri, 31 Aug 2012 20:24:51 +0530	[thread overview]
Message-ID: <5040D03B.2050304@ti.com> (raw)

Hi Russell & Tony,

AM335X EVM (based on AM33XX device) only supports DT boot mode and
doesn't have CONFIG_MACH_AM335XEVM option defined. Some time back during
baseport submission we had aligned that, we won't create separate EVM
options, killing the board file all-together.

Having said that, the early printk option (DEBUG_LL) is broken, the
auto-generated file "./include/generated/mach-types.h" still refers to
CONFIG_MACH_AM335XEVM option,

#ifdef CONFIG_MACH_AM335XEVM
# ifdef machine_arch_type
#  undef machine_arch_type
#  define machine_arch_type     __machine_arch_type
# else
#  define machine_arch_type     MACH_TYPE_AM335XEVM
# endif
# define machine_is_am335xevm() (machine_arch_type == MACH_TYPE_AM335XEVM)
#else
# define machine_is_am335xevm() (0)
#endif


So I am thinking of changing the config_xxx option to SOC_AM33XX or
ARCH_OMAP2PLUS, something like below,

am335xevm        SOC_AM33XX          AM335XEVM         3589

OR

am335xevm        ARCH_OMAP2PLUS      AM335XEVM         3589


Can you comment on this? Based on that I will submit the patch.

Thanks,
Vaibhav

             reply	other threads:[~2012-08-31 14:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31 14:54 Vaibhav Hiremath [this message]
2012-08-31 14:54 ` Without MACH_ option Early printk (DEBUG_LL) Vaibhav Hiremath
2012-08-31 15:52 ` Tony Lindgren
2012-08-31 15:52   ` Tony Lindgren
2012-08-31 16:06   ` Hiremath, Vaibhav
2012-08-31 16:06     ` Hiremath, Vaibhav
2012-08-31 16:11     ` Tony Lindgren
2012-08-31 16:11       ` Tony Lindgren
2012-08-31 16:37       ` Hiremath, Vaibhav
2012-08-31 16:37         ` Hiremath, Vaibhav
2012-08-31 16:47       ` Hiremath, Vaibhav
2012-08-31 16:47         ` Hiremath, Vaibhav
2012-08-31 17:06         ` Tony Lindgren
2012-08-31 17:06           ` Tony Lindgren
2012-08-31 17:13 ` Russell King - ARM Linux
2012-08-31 17:13   ` Russell King - ARM Linux
2012-08-31 17:23   ` Hiremath, Vaibhav
2012-08-31 17:23     ` Hiremath, Vaibhav
2012-08-31 18:23     ` Nicolas Pitre
2012-08-31 18:23       ` Nicolas Pitre
2012-09-03  4:27       ` Mohammed, Afzal
2012-09-03  4:27         ` Mohammed, Afzal
2012-09-04  2:04         ` Nicolas Pitre
2012-09-04  2:04           ` Nicolas Pitre
2012-09-04  4:27           ` Hiremath, Vaibhav
2012-09-04  4:27             ` Hiremath, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5040D03B.2050304@ti.com \
    --to=hvaibhav@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.