From: Stefan Weil <sw@weilnetz.de>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-stable@nongnu.org" <qemu-stable@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow
Date: Sat, 01 Sep 2012 08:49:04 +0200 [thread overview]
Message-ID: <5041AFE0.5070809@weilnetz.de> (raw)
In-Reply-To: <0CD423D9-2A2E-46E5-B0B3-63D6E044436A@suse.de>
Am 01.09.2012 08:23, schrieb Alexander Graf:
>
>
> On 31.08.2012, at 22:45, Markus Armbruster <armbru@redhat.com> wrote:
>
>> Andreas Färber <afaerber@suse.de> writes:
>> static uint32_t dcr_read_pob (void *opaque, int dcrn)
...
>>
>>>
>>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>>
>>> We could alternatively leave besr[2] and access it with hardcoded 0..1.
>>
>> Minimally invasive fix would be besr[dcrn != POB0_BESR0].
>>
>> [...]
>
> I don't think the change is important enough for these stylistic questions :). I'll just apply it once I'm back to a real internet connection.
>
> Alex
Of course I considered those minimally invasive solutions.
There was already other code in the same file which used besr0, besr1,
and the wrong statements were simple enough to justify a duplication.
If I were a compiler, I'd generate smaller and faster code with the
new code :-)
Cheers,
Stefan W.
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-stable@nongnu.org" <qemu-stable@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow
Date: Sat, 01 Sep 2012 08:49:04 +0200 [thread overview]
Message-ID: <5041AFE0.5070809@weilnetz.de> (raw)
In-Reply-To: <0CD423D9-2A2E-46E5-B0B3-63D6E044436A@suse.de>
Am 01.09.2012 08:23, schrieb Alexander Graf:
>
>
> On 31.08.2012, at 22:45, Markus Armbruster <armbru@redhat.com> wrote:
>
>> Andreas Färber <afaerber@suse.de> writes:
>> static uint32_t dcr_read_pob (void *opaque, int dcrn)
...
>>
>>>
>>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>>
>>> We could alternatively leave besr[2] and access it with hardcoded 0..1.
>>
>> Minimally invasive fix would be besr[dcrn != POB0_BESR0].
>>
>> [...]
>
> I don't think the change is important enough for these stylistic questions :). I'll just apply it once I'm back to a real internet connection.
>
> Alex
Of course I considered those minimally invasive solutions.
There was already other code in the same file which used besr0, besr1,
and the wrong statements were simple enough to justify a duplication.
If I were a compiler, I'd generate smaller and faster code with the
new code :-)
Cheers,
Stefan W.
next prev parent reply other threads:[~2012-09-01 6:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 20:21 [Qemu-trivial] [PATCH] ppc405_uc: Fix buffer overflow Stefan Weil
2012-08-31 20:21 ` [Qemu-devel] " Stefan Weil
2012-08-31 21:36 ` [Qemu-trivial] " Andreas Färber
2012-08-31 21:36 ` Andreas Färber
2012-09-01 5:45 ` [Qemu-trivial] " Markus Armbruster
2012-09-01 5:45 ` Markus Armbruster
2012-09-01 6:23 ` [Qemu-trivial] " Alexander Graf
2012-09-01 6:23 ` Alexander Graf
2012-09-01 6:49 ` Stefan Weil [this message]
2012-09-01 6:49 ` Stefan Weil
2012-09-20 9:33 ` [Qemu-trivial] " Alexander Graf
2012-09-20 9:33 ` [Qemu-devel] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5041AFE0.5070809@weilnetz.de \
--to=sw@weilnetz.de \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.