* [Qemu-trivial] [PATCH] target-i386: Report on error during cpu_x86_register().
@ 2012-09-01 20:47 ` Don Slutz
0 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-01 20:47 UTC (permalink / raw)
To: qemu-devel, qemu-devel; +Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..5c0fef1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
@ 2012-09-01 20:47 ` Don Slutz
0 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-01 20:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..5c0fef1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
2012-09-01 20:47 ` [Qemu-devel] " Don Slutz
@ 2012-09-02 10:54 ` Blue Swirl
-1 siblings, 0 replies; 10+ messages in thread
From: Blue Swirl @ 2012-09-02 10:54 UTC (permalink / raw)
To: Don Slutz; +Cc: qemu-trivial, qemu-devel
On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz <Don@cloudswitch.com> wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..5c0fef1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
__func__ is preferred by checkpatch.pl and also GCC recommends using it:
http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
> error_free(error);
> return -1;
> }
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
@ 2012-09-02 10:54 ` Blue Swirl
0 siblings, 0 replies; 10+ messages in thread
From: Blue Swirl @ 2012-09-02 10:54 UTC (permalink / raw)
To: Don Slutz; +Cc: qemu-trivial, qemu-devel
On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz <Don@cloudswitch.com> wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..5c0fef1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
__func__ is preferred by checkpatch.pl and also GCC recommends using it:
http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
> error_free(error);
> return -1;
> }
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
2012-09-02 10:54 ` Blue Swirl
@ 2012-09-02 23:40 ` Don Slutz
-1 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-02 23:40 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-trivial, qemu-devel
Blue Swirl wrote:
> On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz <Don@cloudswitch.com> wrote:
>
>> Send it to stderr before free of the details.
>>
>> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
>> ---
>> target-i386/cpu.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index 57c064f..5c0fef1 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
>> }
>> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
>> if (error_is_set(&error)) {
>> + fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
>>
>
> __func__ is preferred by checkpatch.pl and also GCC recommends using it:
> http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
>
>
>> error_free(error);
>> return -1;
>> }
>> --
>> 1.7.1
>>
>>
>>
Somehow I forgot to run checkpatch.pl on this. V2 soon.
-Don
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
@ 2012-09-02 23:40 ` Don Slutz
0 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-02 23:40 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-trivial, qemu-devel
Blue Swirl wrote:
> On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz <Don@cloudswitch.com> wrote:
>
>> Send it to stderr before free of the details.
>>
>> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
>> ---
>> target-i386/cpu.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index 57c064f..5c0fef1 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
>> }
>> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
>> if (error_is_set(&error)) {
>> + fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
>>
>
> __func__ is preferred by checkpatch.pl and also GCC recommends using it:
> http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
>
>
>> error_free(error);
>> return -1;
>> }
>> --
>> 1.7.1
>>
>>
>>
Somehow I forgot to run checkpatch.pl on this. V2 soon.
-Don
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-trivial] [PATCH v2] target-i386: Report on error during cpu_x86_register().
2012-09-01 20:47 ` [Qemu-devel] " Don Slutz
@ 2012-09-03 0:09 ` Don Slutz
-1 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-03 0:09 UTC (permalink / raw)
To: qemu-devel, blauwirbel, qemu-devel, blauwirbel; +Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
v2: Change __FUNCTION__ to __func__
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..760cca4 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
@ 2012-09-03 0:09 ` Don Slutz
0 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-03 0:09 UTC (permalink / raw)
To: qemu-devel, blauwirbel; +Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
v2: Change __FUNCTION__ to __func__
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..760cca4 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [PATCH v2] target-i386: Report on error during cpu_x86_register().
2012-09-03 0:09 ` [Qemu-devel] " Don Slutz
@ 2012-09-11 14:13 ` Don Slutz
-1 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-11 14:13 UTC (permalink / raw)
To: Don Slutz; +Cc: blauwirbel, qemu-trivial, qemu-devel
On 09/02/12 20:09, Don Slutz wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> v2: Change __FUNCTION__ to __func__
>
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..760cca4 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
> error_free(error);
> return -1;
> }
The (3) patch set in
http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg01400.html
includes this change, and so this request is being withdrawn.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
@ 2012-09-11 14:13 ` Don Slutz
0 siblings, 0 replies; 10+ messages in thread
From: Don Slutz @ 2012-09-11 14:13 UTC (permalink / raw)
To: Don Slutz; +Cc: blauwirbel, qemu-trivial, qemu-devel
On 09/02/12 20:09, Don Slutz wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> v2: Change __FUNCTION__ to __func__
>
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..760cca4 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
> error_free(error);
> return -1;
> }
The (3) patch set in
http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg01400.html
includes this change, and so this request is being withdrawn.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-09-11 14:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-01 20:47 [Qemu-trivial] [PATCH] target-i386: Report on error during cpu_x86_register() Don Slutz
2012-09-01 20:47 ` [Qemu-devel] " Don Slutz
2012-09-02 10:54 ` [Qemu-trivial] " Blue Swirl
2012-09-02 10:54 ` Blue Swirl
2012-09-02 23:40 ` [Qemu-trivial] " Don Slutz
2012-09-02 23:40 ` Don Slutz
2012-09-03 0:09 ` [Qemu-trivial] [PATCH v2] " Don Slutz
2012-09-03 0:09 ` [Qemu-devel] " Don Slutz
2012-09-11 14:13 ` [Qemu-trivial] " Don Slutz
2012-09-11 14:13 ` [Qemu-devel] " Don Slutz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.