* [PATCH] KVM: PIC: fix use of uninitialised variable.
@ 2012-08-30 10:32 Jamie Iles
2012-09-04 12:44 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Jamie Iles @ 2012-08-30 10:32 UTC (permalink / raw)
To: kvm; +Cc: Jamie Iles, Gleb Natapov, Avi Kivity
Commit aea218f3cbbc (KVM: PIC: call ack notifiers for irqs that are
dropped form irr) used an uninitialised variable to track whether an
appropriate apic had been found. This could result in calling the ack
notifier incorrectly.
Cc: Gleb Natapov <gleb@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
arch/x86/kvm/i8259.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index e498b18..9fc9aa7 100644
--- a/arch/x86/kvm/i8259.c
+++ b/arch/x86/kvm/i8259.c
@@ -318,7 +318,7 @@ static void pic_ioport_write(void *opaque, u32 addr, u32 val)
if (val & 0x10) {
u8 edge_irr = s->irr & ~s->elcr;
int i;
- bool found;
+ bool found = false;
struct kvm_vcpu *vcpu;
s->init4 = val & 1;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: PIC: fix use of uninitialised variable.
2012-08-30 10:32 [PATCH] KVM: PIC: fix use of uninitialised variable Jamie Iles
@ 2012-09-04 12:44 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2012-09-04 12:44 UTC (permalink / raw)
To: Jamie Iles; +Cc: kvm, Gleb Natapov
On 08/30/2012 01:32 PM, Jamie Iles wrote:
> Commit aea218f3cbbc (KVM: PIC: call ack notifiers for irqs that are
> dropped form irr) used an uninitialised variable to track whether an
> appropriate apic had been found. This could result in calling the ack
> notifier incorrectly.
Thanks, applied to master for 3.6.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-04 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-30 10:32 [PATCH] KVM: PIC: fix use of uninitialised variable Jamie Iles
2012-09-04 12:44 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.