All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] block/curl: Fix wrong free statement
Date: Tue, 04 Sep 2012 16:11:21 +0200	[thread overview]
Message-ID: <50460C09.8010504@redhat.com> (raw)
In-Reply-To: <1346490405-18889-1-git-send-email-sw@weilnetz.de>

Am 01.09.2012 11:06, schrieb Stefan Weil:
> Report from smatch:
> block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free()
> 
> The check was redundant, and free was also wrong because the memory
> was allocated using g_strdup.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to block-next.

Kevin


WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/curl: Fix wrong free statement
Date: Tue, 04 Sep 2012 16:11:21 +0200	[thread overview]
Message-ID: <50460C09.8010504@redhat.com> (raw)
In-Reply-To: <1346490405-18889-1-git-send-email-sw@weilnetz.de>

Am 01.09.2012 11:06, schrieb Stefan Weil:
> Report from smatch:
> block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free()
> 
> The check was redundant, and free was also wrong because the memory
> was allocated using g_strdup.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to block-next.

Kevin

  reply	other threads:[~2012-09-04 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-01  9:06 [Qemu-trivial] [PATCH] block/curl: Fix wrong free statement Stefan Weil
2012-09-01  9:06 ` [Qemu-devel] " Stefan Weil
2012-09-04 14:11 ` Kevin Wolf [this message]
2012-09-04 14:11   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50460C09.8010504@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.