Re: [PATCH 4/4] MIPS: Remove kernel_uses_smartmips_rixi macro definition.

[David Daney <ddaney.cavm@gmail.com>]

On 09/05/2012 01:27 PM, Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
>
> Remove the 'kernel_uses_smartmips_rixi' macro definitions from
> the architecture header files.
>
> Signed-off-by: Steven J. Hill <sjhill@mips.com>
> ---
>   arch/mips/include/asm/cpu-features.h               |    3 ---
>   .../asm/mach-cavium-octeon/cpu-feature-overrides.h |    2 --
>   2 files changed, 5 deletions(-)
>
> diff --git a/arch/mips/include/asm/cpu-features.h b/arch/mips/include/asm/cpu-features.h
> index c78a77b..7452d78 100644
> --- a/arch/mips/include/asm/cpu-features.h
> +++ b/arch/mips/include/asm/cpu-features.h
> @@ -95,9 +95,6 @@
>   #ifndef cpu_has_smartmips
>   #define cpu_has_smartmips      (cpu_data[0].ases & MIPS_ASE_SMARTMIPS)
>   #endif
> -#ifndef kernel_uses_smartmips_rixi
> -#define kernel_uses_smartmips_rixi 0

As I said in the other message, you will want to have the replacement 
for this instance of kernel_uses_smartmips_rixi in place before you do 
the other conversions.

That said, at the end of the patch set, this does need to go, so 
something like this will be needed.

David Daney

> -#endif
>   #ifndef cpu_has_ri
>   #define cpu_has_ri		(cpu_data[0].options & MIPS_CPU_RI)
>   #endif
> diff --git a/arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h b/arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h
> index a58addb..971bdc2 100644
> --- a/arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h
> +++ b/arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h
> @@ -58,8 +58,6 @@
>   #define cpu_has_veic		0
>   #define cpu_hwrena_impl_bits	0xc0000000
>
> -#define kernel_uses_smartmips_rixi (cpu_data[0].cputype != CPU_CAVIUM_OCTEON)
> -
>   #define ARCH_HAS_IRQ_PER_CPU	1
>   #define ARCH_HAS_SPINLOCK_PREFETCH 1
>   #define spin_lock_prefetch(x) prefetch(x)
>