* [PATCH] Don't truncate the overlay file on a reset.
@ 2012-08-30 1:15 Frederick Grose
[not found] ` <CAEcBt+XLgwWV7GDtrR18aZ6MR1GtZihcWub-CNxL0mr7NS_YpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Frederick Grose @ 2012-08-30 1:15 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA; +Cc: livecd-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A
commit d0d4f29cdd0a0e6dd1170965decb282ef5511746
Author: Frederick Grose <fgrose-agl9EP5VjmEgsBAKwltoeQ@public.gmane.org>
Date: Wed Aug 29 21:02:07 2012 -0400
Don't truncate the overlay file on a reset.
diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh
b/modules.d/90dmsquash-live/dmsquash-live-root.sh
index f8bfca6..62340a5 100755
--- a/modules.d/90dmsquash-live/dmsquash-live-root.sh
+++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh
@@ -98,7 +98,7 @@ do_live_overlay() {
if [ -f /run/initramfs/overlayfs$pathspec -a -w
/run/initramfs/overlayfs$pathspec ]; then
losetup $OVERLAY_LOOPDEV /run/initramfs/overlayfs$pathspec
if [ -n "$reset_overlay" ]; then
- dd if=/dev/zero of=$OVERLAY_LOOPDEV bs=64k count=1 2>/dev/null
+ dd if=/dev/zero of=$OVERLAY_LOOPDEV bs=64k count=1
conv=notrunc 2>/dev/null
fi
setup="yes"
fi
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <CAEcBt+XLgwWV7GDtrR18aZ6MR1GtZihcWub-CNxL0mr7NS_YpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] Don't truncate the overlay file on a reset. [not found] ` <CAEcBt+XLgwWV7GDtrR18aZ6MR1GtZihcWub-CNxL0mr7NS_YpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-08-31 0:19 ` Frederick Grose [not found] ` <CAEcBt+XQLRA-PZ4m7SjhTw3qASkg3s57PYHKOG56g0f5xtdz7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Frederick Grose @ 2012-08-31 0:19 UTC (permalink / raw) To: initramfs-u79uwXL29TY76Z2rM5mHXA; +Cc: livecd-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A On Wed, Aug 29, 2012 at 9:15 PM, Frederick Grose <fgrose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > commit d0d4f29cdd0a0e6dd1170965decb282ef5511746 > Author: Frederick Grose <fgrose-agl9EP5VjmEgsBAKwltoeQ@public.gmane.org> > Date: Wed Aug 29 21:02:07 2012 -0400 > > Don't truncate the overlay file on a reset. > > diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh > b/modules.d/90dmsquash-live/dmsquash-live-root.sh > index f8bfca6..62340a5 100755 > --- a/modules.d/90dmsquash-live/dmsquash-live-root.sh > +++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh > @@ -98,7 +98,7 @@ do_live_overlay() { > if [ -f /run/initramfs/overlayfs$pathspec -a -w > /run/initramfs/overlayfs$pathspec ]; then > losetup $OVERLAY_LOOPDEV /run/initramfs/overlayfs$pathspec > if [ -n "$reset_overlay" ]; then > - dd if=/dev/zero of=$OVERLAY_LOOPDEV bs=64k count=1 2>/dev/null > + dd if=/dev/zero of=$OVERLAY_LOOPDEV bs=64k count=1 > conv=notrunc 2>/dev/null > fi > setup="yes" > fi Void the above patch. I don't know why the overlay is NOT truncated without the notrunc conversion argument to dd. However, my testing shows that this bug is fixed by using the fsync conversion argument, https://bugzilla.redhat.com/show_bug.cgi?id=832884 A revised patch file is attached to the bug ticket. --Fred ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CAEcBt+XQLRA-PZ4m7SjhTw3qASkg3s57PYHKOG56g0f5xtdz7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] Don't truncate the overlay file on a reset. [not found] ` <CAEcBt+XQLRA-PZ4m7SjhTw3qASkg3s57PYHKOG56g0f5xtdz7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-09-06 8:51 ` Harald Hoyer 0 siblings, 0 replies; 3+ messages in thread From: Harald Hoyer @ 2012-09-06 8:51 UTC (permalink / raw) To: Frederick Grose Cc: initramfs-u79uwXL29TY76Z2rM5mHXA, livecd-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A Am 31.08.2012 02:19, schrieb Frederick Grose: > On Wed, Aug 29, 2012 at 9:15 PM, Frederick Grose <fgrose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >> commit d0d4f29cdd0a0e6dd1170965decb282ef5511746 >> Author: Frederick Grose <fgrose-agl9EP5VjmEgsBAKwltoeQ@public.gmane.org> >> Date: Wed Aug 29 21:02:07 2012 -0400 >> >> Don't truncate the overlay file on a reset. >> >> diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh >> b/modules.d/90dmsquash-live/dmsquash-live-root.sh >> index f8bfca6..62340a5 100755 >> --- a/modules.d/90dmsquash-live/dmsquash-live-root.sh >> +++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh >> @@ -98,7 +98,7 @@ do_live_overlay() { >> if [ -f /run/initramfs/overlayfs$pathspec -a -w >> /run/initramfs/overlayfs$pathspec ]; then >> losetup $OVERLAY_LOOPDEV /run/initramfs/overlayfs$pathspec >> if [ -n "$reset_overlay" ]; then >> - dd if=/dev/zero of=$OVERLAY_LOOPDEV bs=64k count=1 2>/dev/null >> + dd if=/dev/zero of=$OVERLAY_LOOPDEV bs=64k count=1 >> conv=notrunc 2>/dev/null >> fi >> setup="yes" >> fi > > Void the above patch. > > I don't know why the overlay is NOT truncated without the notrunc > conversion argument to dd. > > However, my testing shows that this bug is fixed by using the fsync > conversion argument, > https://bugzilla.redhat.com/show_bug.cgi?id=832884 > > A revised patch file is attached to the bug ticket. > > --Fred bugzilla attachment applied, thanks! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-06 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-30 1:15 [PATCH] Don't truncate the overlay file on a reset Frederick Grose
[not found] ` <CAEcBt+XLgwWV7GDtrR18aZ6MR1GtZihcWub-CNxL0mr7NS_YpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-31 0:19 ` Frederick Grose
[not found] ` <CAEcBt+XQLRA-PZ4m7SjhTw3qASkg3s57PYHKOG56g0f5xtdz7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-06 8:51 ` Harald Hoyer
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.