Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

["Andreas Färber" <afaerber@suse.de>]

Am 06.09.2012 10:44, schrieb Jan Kiszka:
> On 2012-08-30 20:30, Jan Kiszka wrote:
>> This adds PCI device assignment for i386 targets using the classic KVM
>> interfaces. This version is 100% identical to what is being maintained
>> in qemu-kvm for several years and is supported by libvirt as well. It is
>> expected to remain relevant for another couple of years until kernels
>> without full-features and performance-wise equivalent VFIO support are
>> obsolete.
>>
>> A refactoring to-do that should be done in-tree is to model MSI and
>> MSI-X support via the generic PCI layer, similar to what VFIO is already
>> doing for MSI-X. This should improve the correctness and clean up the
>> code from duplicate logic.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Changes in v3:
>>  - addressed comment by Peter (changed device name to kvm-pci-assign +
>>    alias)
>>  - addressed (most) comments by Michael
>>  - fixed INT pin regression
> 
> Does someone _disagree_ that there are no open (and reasonably solvable)
> issues and that this can now be merged through uq/master?

My implicit suggestion was to add a notice that new patch contributions
to the file from date yyyy-mm-dd on would be declared GPLv2+, as Paolo
has done elsewhere. That would limit the amount of people to ask for a
potential relicensing attempt.

For the record, Anthony explained on IRC that the code originated from
Xen originally and thus qemu-kvm.git does not contain the full history
anyway and that pulling in the Mercurial file history and replaying the
KVM history on top was too difficult, therefore this patch with a single
SoB by Jan.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg